Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Unified Diff: components/password_manager/core/browser/password_manager_driver.h

Issue 208453002: Add "previewing on hover" support for password field. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update code as per review comments on SelectionRange. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_manager_driver.h
diff --git a/components/password_manager/core/browser/password_manager_driver.h b/components/password_manager/core/browser/password_manager_driver.h
index 8087af7a9367aa78460eb6c80ad753bb35c98984..8260939570ec2979065e10d0d8782bcd9c8b1fcb 100644
--- a/components/password_manager/core/browser/password_manager_driver.h
+++ b/components/password_manager/core/browser/password_manager_driver.h
@@ -45,11 +45,17 @@ class PasswordManagerDriver {
virtual void AccountCreationFormsFound(
const std::vector<autofill::FormData>& forms) = 0;
- // Tells the driver to accept the password autofill suggestion for |username|
- // and fill the password with |password|.
- virtual void AcceptPasswordAutofillSuggestion(
- const base::string16& username,
- const base::string16& password) = 0;
+ // Tells the driver to fill the form with the |username| and |password|.
+ virtual void FillSuggestion(const base::string16& username,
+ const base::string16& password) = 0;
+
+ // Tells the driver to preview filling form with the |username| and
+ // |password|.
+ virtual void PreviewSuggestion(const base::string16& username,
+ const base::string16& password) = 0;
+
+ // Tells the driver to clear previewed password and username fields.
+ virtual void ClearPreviewedForm() = 0;
// Returns the PasswordGenerationManager associated with this instance.
virtual PasswordGenerationManager* GetPasswordGenerationManager() = 0;

Powered by Google App Engine
This is Rietveld 408576698