Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Unified Diff: components/password_manager/core/browser/password_generation_manager_unittest.cc

Issue 208453002: Add "previewing on hover" support for password field. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update code as per review comments on SelectionRange. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_generation_manager_unittest.cc
diff --git a/components/password_manager/core/browser/password_generation_manager_unittest.cc b/components/password_manager/core/browser/password_generation_manager_unittest.cc
index 2187c214d99f3539a71cbc29da053b61098ec40c..ade89a20c880b50d39461dafb23c2d5a9d2c823d 100644
--- a/components/password_manager/core/browser/password_generation_manager_unittest.cc
+++ b/components/password_manager/core/browser/password_generation_manager_unittest.cc
@@ -60,10 +60,11 @@ class TestPasswordManagerDriver : public PasswordManagerDriver {
found_account_creation_forms_.insert(
found_account_creation_forms_.begin(), forms.begin(), forms.end());
}
- virtual void AcceptPasswordAutofillSuggestion(
- const base::string16& username,
- const base::string16& password) OVERRIDE {
- }
+ virtual void FillSuggestion(const base::string16& username,
+ const base::string16& password) OVERRIDE {}
+ virtual void PreviewSuggestion(const base::string16& username,
+ const base::string16& password) OVERRIDE {}
+ virtual void ClearPreviewedForm() OVERRIDE {}
const std::vector<autofill::FormData>& GetFoundAccountCreationForms() {
return found_account_creation_forms_;

Powered by Google App Engine
This is Rietveld 408576698