Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Unified Diff: components/password_manager/core/browser/password_manager_driver.h

Issue 208453002: Add "previewing on hover" support for password field. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Improve rebased code. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_manager_driver.h
diff --git a/components/password_manager/core/browser/password_manager_driver.h b/components/password_manager/core/browser/password_manager_driver.h
index 8087af7a9367aa78460eb6c80ad753bb35c98984..78e38097b1c847092110fb6a9ff7f4b4c746d9f4 100644
--- a/components/password_manager/core/browser/password_manager_driver.h
+++ b/components/password_manager/core/browser/password_manager_driver.h
@@ -51,6 +51,15 @@ class PasswordManagerDriver {
const base::string16& username,
const base::string16& password) = 0;
+ // Tells the driver to select the password autofill suggestion for |username|
+ // and preview the password with |password|.
Ilya Sherman 2014/05/13 00:44:05 nit: "Tells the driver to preview filling form wit
ziran.sun 2014/05/14 15:35:12 Done.
+ virtual void PreviewPasswordAutofillSuggestion(
+ const base::string16& username,
+ const base::string16& password) = 0;
Ilya Sherman 2014/05/13 00:44:05 nit: I'd recommend renaming these two methods to F
ziran.sun 2014/05/14 15:35:12 Done.
+
+ // Clear previewed password and username fields.
+ virtual void ClearPasswordPreviewedForm() = 0;
Ilya Sherman 2014/05/13 00:44:05 nit: "ClearPreviewedForm"
ziran.sun 2014/05/14 15:35:12 Done.
+
// Returns the PasswordGenerationManager associated with this instance.
virtual PasswordGenerationManager* GetPasswordGenerationManager() = 0;

Powered by Google App Engine
This is Rietveld 408576698