Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Side by Side Diff: components/password_manager/core/browser/password_manager_driver.h

Issue 208453002: Add "previewing on hover" support for password field. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Improve rebased code. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_MANAGER_DRIVER_H_ 5 #ifndef COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_MANAGER_DRIVER_H_
6 #define COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_MANAGER_DRIVER_H_ 6 #define COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_MANAGER_DRIVER_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 namespace autofill { 10 namespace autofill {
(...skipping 28 matching lines...) Expand all
39 virtual bool IsOffTheRecord() = 0; 39 virtual bool IsOffTheRecord() = 0;
40 40
41 // Informs the driver that |form| can be used for password generation. 41 // Informs the driver that |form| can be used for password generation.
42 virtual void AllowPasswordGenerationForForm(autofill::PasswordForm* form) = 0; 42 virtual void AllowPasswordGenerationForForm(autofill::PasswordForm* form) = 0;
43 43
44 // Notifies the driver that account creation |forms| were found. 44 // Notifies the driver that account creation |forms| were found.
45 virtual void AccountCreationFormsFound( 45 virtual void AccountCreationFormsFound(
46 const std::vector<autofill::FormData>& forms) = 0; 46 const std::vector<autofill::FormData>& forms) = 0;
47 47
48 // Tells the driver to accept the password autofill suggestion for |username| 48 // Tells the driver to accept the password autofill suggestion for |username|
49 // and fill the password with |password|. 49 // and fill the password with |password|.
Ilya Sherman 2014/05/13 00:44:05 nit: "Tells the driver to fill the form with the |
ziran.sun 2014/05/14 15:35:12 Done.
50 virtual void AcceptPasswordAutofillSuggestion( 50 virtual void AcceptPasswordAutofillSuggestion(
51 const base::string16& username, 51 const base::string16& username,
52 const base::string16& password) = 0; 52 const base::string16& password) = 0;
53 53
54 // Tells the driver to select the password autofill suggestion for |username|
55 // and preview the password with |password|.
Ilya Sherman 2014/05/13 00:44:05 nit: "Tells the driver to preview filling form wit
ziran.sun 2014/05/14 15:35:12 Done.
56 virtual void PreviewPasswordAutofillSuggestion(
57 const base::string16& username,
58 const base::string16& password) = 0;
Ilya Sherman 2014/05/13 00:44:05 nit: I'd recommend renaming these two methods to F
ziran.sun 2014/05/14 15:35:12 Done.
59
60 // Clear previewed password and username fields.
61 virtual void ClearPasswordPreviewedForm() = 0;
Ilya Sherman 2014/05/13 00:44:05 nit: "ClearPreviewedForm"
ziran.sun 2014/05/14 15:35:12 Done.
62
54 // Returns the PasswordGenerationManager associated with this instance. 63 // Returns the PasswordGenerationManager associated with this instance.
55 virtual PasswordGenerationManager* GetPasswordGenerationManager() = 0; 64 virtual PasswordGenerationManager* GetPasswordGenerationManager() = 0;
56 65
57 // Returns the PasswordManager associated with this instance. 66 // Returns the PasswordManager associated with this instance.
58 virtual PasswordManager* GetPasswordManager() = 0; 67 virtual PasswordManager* GetPasswordManager() = 0;
59 68
60 // Returns the PasswordAutofillManager associated with this instance. 69 // Returns the PasswordAutofillManager associated with this instance.
61 virtual PasswordAutofillManager* GetPasswordAutofillManager() = 0; 70 virtual PasswordAutofillManager* GetPasswordAutofillManager() = 0;
62 71
63 // Returns the AutofillManager associated with this instance. 72 // Returns the AutofillManager associated with this instance.
64 virtual autofill::AutofillManager* GetAutofillManager() = 0; 73 virtual autofill::AutofillManager* GetAutofillManager() = 0;
65 74
66 private: 75 private:
67 DISALLOW_COPY_AND_ASSIGN(PasswordManagerDriver); 76 DISALLOW_COPY_AND_ASSIGN(PasswordManagerDriver);
68 }; 77 };
69 78
70 } // namespace password_manager 79 } // namespace password_manager
71 80
72 #endif // COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_MANAGER_DRIVER_H_ 81 #endif // COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_MANAGER_DRIVER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698