Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: components/autofill/content/browser/content_autofill_driver.cc

Issue 208453002: Add "previewing on hover" support for password field. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update code as per Ilya's comment. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/browser/content_autofill_driver.cc
diff --git a/components/autofill/content/browser/content_autofill_driver.cc b/components/autofill/content/browser/content_autofill_driver.cc
index 93e44550154d6cc659377e42b9ed2e2a96007155..9983276e4629ef6023d99f6148b92af8150c7fc2 100644
--- a/components/autofill/content/browser/content_autofill_driver.cc
+++ b/components/autofill/content/browser/content_autofill_driver.cc
@@ -133,7 +133,7 @@ void ContentAutofillDriver::RendererShouldAcceptDataListSuggestion(
new AutofillMsg_AcceptDataListSuggestion(host->GetRoutingID(), value));
}
-void ContentAutofillDriver::RendererShouldAcceptPasswordAutofillSuggestion(
+void ContentAutofillDriver::RendererShouldFillPassword(
const base::string16& username) {
if (!RendererIsAvailable())
return;
@@ -142,6 +142,15 @@ void ContentAutofillDriver::RendererShouldAcceptPasswordAutofillSuggestion(
host->GetRoutingID(), username));
}
+void ContentAutofillDriver::RendererShouldPreviewPassword(
+ const base::string16& username) {
+ if (!RendererIsAvailable())
+ return;
+ content::RenderViewHost* host = web_contents()->GetRenderViewHost();
+ host->Send(
+ new AutofillMsg_PreviewPassword(host->GetRoutingID(), username));
+}
+
void ContentAutofillDriver::RendererShouldClearFilledForm() {
if (!RendererIsAvailable())
return;

Powered by Google App Engine
This is Rietveld 408576698