Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: components/autofill/content/browser/content_autofill_driver.h

Issue 208453002: Add "previewing on hover" support for password field. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update code as per Ilya's comment. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/browser/content_autofill_driver.h
diff --git a/components/autofill/content/browser/content_autofill_driver.h b/components/autofill/content/browser/content_autofill_driver.h
index a5076794d9828f2545ae1801b3c2261db157b921..997f42cc711f7518f9907bacb75049890726e165 100644
--- a/components/autofill/content/browser/content_autofill_driver.h
+++ b/components/autofill/content/browser/content_autofill_driver.h
@@ -54,7 +54,9 @@ class ContentAutofillDriver : public AutofillDriver,
const std::vector<FormStructure*>& forms) OVERRIDE;
virtual void RendererShouldAcceptDataListSuggestion(
const base::string16& value) OVERRIDE;
- virtual void RendererShouldAcceptPasswordAutofillSuggestion(
+ virtual void RendererShouldFillPassword(
+ const base::string16& username) OVERRIDE;
+ virtual void RendererShouldPreviewPassword(
const base::string16& username) OVERRIDE;
virtual void RendererShouldClearFilledForm() OVERRIDE;
virtual void RendererShouldClearPreviewedForm() OVERRIDE;

Powered by Google App Engine
This is Rietveld 408576698