ash/wm/maximize_mode/maximize_mode_window_manager.cc - Issue 2084503007: Moves WindowSelectorController onto WmShell

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/wm/maximize_mode/maximize_mode_window_manager.cc

Issue 2084503007: Moves WindowSelectorController onto WmShell (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move_overview

Patch Set: fix mash Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/wm/maximize_mode/maximize_mode_window_manager.cc

diff --git a/ash/wm/maximize_mode/maximize_mode_window_manager.cc b/ash/wm/maximize_mode/maximize_mode_window_manager.cc

index ccce256b168f93d83b511c89e0aede837785c4e9..1b9914da689bdb1ec9436f6acf01ee33f8336c1a 100644

--- a/ash/wm/maximize_mode/maximize_mode_window_manager.cc

+++ b/ash/wm/maximize_mode/maximize_mode_window_manager.cc

@@ -36,8 +36,8 @@ const int kLeaveFullScreenAreaHeightInPixel = 2;

// Exits overview mode if it is currently active.

void CancelOverview() {

WindowSelectorController* controller =

- Shell::GetInstance()->window_selector_controller();

- if (controller && controller->IsSelecting())

+ WmShell::Get()->window_selector_controller();

+ if (controller->IsSelecting())

controller->OnSelectionEnded();

}