Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 2084493003: Reland of [Android] Ensure perf test runner does not create shards for blacklisted devices. (Closed)

Created:
4 years, 6 months ago by perezju
Modified:
4 years, 6 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of [Android] Ensure perf test runner does not create shards for blacklisted devices. (patchset #1 id:1 of https://codereview.chromium.org/2059253002/ ) Reason for revert: CL wasn't responsible for the v8 breakage Original issue's description: > Revert of [Android] Ensure perf test runner does not create shards for blacklisted devices. (patchset #4 id:60001 of https://codereview.chromium.org/2039363002/ ) > > Reason for revert: > Possibly breaking v8 perf bots. > > Original issue's description: > > [Android] Ensure perf test runner does not create shards for blacklisted devices. > > > > BUG=617559 > > > > Committed: https://crrev.com/15c70d1120b419bc68a484d8ecce5773433466f0 > > Cr-Commit-Position: refs/heads/master@{#398197} > > TBR=jbudorick@chromium.org,perezju@chromium.org,mikecase@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=617559 > > Committed: https://crrev.com/c89b1748ad3fee34318dd63b32e881a7361743ce > Cr-Commit-Position: refs/heads/master@{#399460} TBR=jbudorick@chromium.org,mikecase@chromium.org,rnephew@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=617559 Committed: https://crrev.com/e0ce69beeada5f4918d278c5cf8afe10165e84ce Cr-Commit-Position: refs/heads/master@{#400659}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M build/android/pylib/base/test_dispatcher.py View 1 chunk +6 lines, -2 lines 0 comments Download
M build/android/pylib/perf/setup.py View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
perezju
Created Reland of [Android] Ensure perf test runner does not create shards for blacklisted devices.
4 years, 6 months ago (2016-06-20 11:23:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2084493003/1
4 years, 6 months ago (2016-06-20 11:23:43 UTC) #3
jbudorick
lgtm
4 years, 6 months ago (2016-06-20 11:32:41 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-20 12:30:48 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 12:33:14 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e0ce69beeada5f4918d278c5cf8afe10165e84ce
Cr-Commit-Position: refs/heads/master@{#400659}

Powered by Google App Engine
This is Rietveld 408576698