build/android/pylib/perf/setup.py - Issue 2084493003: Reland of [Android] Ensure perf test runner does not create shards for blacklisted devices.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/perf/setup.py

Issue 2084493003: Reland of [Android] Ensure perf test runner does not create shards for blacklisted devices. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/pylib/perf/setup.py

diff --git a/build/android/pylib/perf/setup.py b/build/android/pylib/perf/setup.py

index 31db14fa031e0cccfe8b573bb6bc0b56f9dbaaeb..b3aa086242a39e8c41d42d4e41eef28639c2a617 100644

--- a/build/android/pylib/perf/setup.py

+++ b/build/android/pylib/perf/setup.py

@@ -98,8 +98,10 @@

flaky_steps = json.load(f)

def TestRunnerFactory(device, shard_index):

- return test_runner.TestRunner(

- test_options, device, shard_index, len(all_devices),

- steps_dict, flaky_steps)

+ if str(device) in active_devices:

+ return test_runner.TestRunner(

+ test_options, device, shard_index, len(all_devices),

+ steps_dict, flaky_steps)

+ return None

return (TestRunnerFactory, sorted_step_names, all_devices)

« no previous file with comments | « build/android/pylib/base/test_dispatcher.py ('k') | no next file » | no next file with comments »