Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 2084453002: Initialise and use ChannelMojo to the service utility process. (Closed)

Created:
4 years, 6 months ago by Anand Mistry (off Chromium)
Modified:
4 years, 6 months ago
Reviewers:
Lei Zhang, forshaw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Initialise and use ChannelMojo to the service utility process. BUG=604282 Committed: https://crrev.com/d41a8eecde69132e7b9aae365dfb7568debceec0 Cr-Commit-Position: refs/heads/master@{#400881}

Patch Set 1 #

Patch Set 2 : fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -7 lines) Patch
M chrome/chrome.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/service/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/service/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/service/service_process.h View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/service/service_process.cc View 3 chunks +8 lines, -0 lines 0 comments Download
M chrome/service/service_utility_process_host.h View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/service/service_utility_process_host.cc View 1 5 chunks +40 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Anand Mistry (off Chromium)
A step towards "death to legacy IPC". WDYT? I had to build and test this ...
4 years, 6 months ago (2016-06-20 06:22:01 UTC) #2
Lei Zhang
lgtm
4 years, 6 months ago (2016-06-20 16:37:54 UTC) #3
Anand Mistry (off Chromium)
+forshaw: for security because you reviewed the related https://codereview.chromium.org/1893313003 and this change uses it.
4 years, 6 months ago (2016-06-20 21:25:23 UTC) #5
forshaw
On 2016/06/20 21:25:23, Anand Mistry wrote: > +forshaw: for security because you reviewed the related ...
4 years, 6 months ago (2016-06-21 00:52:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2084453002/20001
4 years, 6 months ago (2016-06-21 03:17:07 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-21 03:21:38 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 03:23:41 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d41a8eecde69132e7b9aae365dfb7568debceec0
Cr-Commit-Position: refs/heads/master@{#400881}

Powered by Google App Engine
This is Rietveld 408576698