Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Issue 2084393002: Revert of [tools/perf] Keep both browsers open from the start of dual browser test (Closed)

Created:
4 years, 6 months ago by perezju
Modified:
4 years, 6 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [tools/perf] Keep both browsers open from the start of dual browser test (patchset #1 id:1 of https://codereview.chromium.org/2073713003/ ) Reason for revert: Broke WPR on the benchmark Original issue's description: > [tools/perf] Keep both browsers open from the start of dual browser test > > At the start of the story set, open the browsers associated with all > stories. This makes sure that, when taking memory dumps, we always get > a dump for all browsers all the time. > > BUG=616043 > > Committed: https://crrev.com/f41edc4cf5d1b086ad00d70bf9fcb51d3fe9183e > Cr-Commit-Position: refs/heads/master@{#400667} TBR=nednguyen@google.com,primiano@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=616043 Committed: https://crrev.com/a0abfdfa0a7131d8dc12f7baf3cc4d76e4e5ea71 Cr-Commit-Position: refs/heads/master@{#401264}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M tools/perf/page_sets/dual_browser_story.py View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
perezju
Created Revert of [tools/perf] Keep both browsers open from the start of dual browser test
4 years, 6 months ago (2016-06-22 12:00:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2084393002/1
4 years, 6 months ago (2016-06-22 12:00:34 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-22 12:59:02 UTC) #4
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 13:02:10 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a0abfdfa0a7131d8dc12f7baf3cc4d76e4e5ea71
Cr-Commit-Position: refs/heads/master@{#401264}

Powered by Google App Engine
This is Rietveld 408576698