tools/perf/page_sets/dual_browser_story.py - Issue 2084393002: Revert of [tools/perf] Keep both browsers open from the start of dual browser test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/page_sets/dual_browser_story.py

Issue 2084393002: Revert of [tools/perf] Keep both browsers open from the start of dual browser test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/page_sets/dual_browser_story.py

diff --git a/tools/perf/page_sets/dual_browser_story.py b/tools/perf/page_sets/dual_browser_story.py

index 036a9297fd10d633a4b4bc7f24c863a41f6b0355..e511044f5dcf4e1a0f5d10fa6c7851feb313fd53 100644

--- a/tools/perf/page_sets/dual_browser_story.py

+++ b/tools/perf/page_sets/dual_browser_story.py

@@ -101,11 +101,6 @@

self.platform.network_controller.Open(wpr_mode,

browser_options.extra_wpr_args)

- # Make sure all browsers are open before starting.

- for story in story_set:

- if story.browser_type not in self._browsers:

- self._SetCurrentBrowser(story.browser_type)

@property

def current_tab(self):

return self._current_tab

« no previous file with comments | « no previous file | no next file » | no next file with comments »