Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 2084343002: v8_inspector: fix compat with V8 5.1 (Closed)

Created:
4 years, 6 months ago by targos
Modified:
4 years, 5 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

v8_inspector: fix compat with V8 5.1 R=pfeldman@chromium.org BUG= Committed: https://crrev.com/15c520d2190759f91d23af9b9d20419374af05f6 Cr-Commit-Position: refs/heads/master@{#403438}

Patch Set 1 #

Patch Set 2 : v8_inspector: fix comment in V8Compat #

Patch Set 3 : change my email in AUTHORS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M AUTHORS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8Compat.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 32 (16 generated)
targos
4 years, 6 months ago (2016-06-22 10:45:33 UTC) #1
pfeldman
On 2016/06/22 10:45:33, targos wrote: https://codereview.chromium.org/2081233002/ took care of it. yours is better, but that ...
4 years, 6 months ago (2016-06-22 19:18:14 UTC) #2
targos
Following @ofrobots suggestion, I updated the CL just to fix the comment.
4 years, 5 months ago (2016-06-27 06:59:47 UTC) #6
pfeldman
lgtm
4 years, 5 months ago (2016-06-27 07:27:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2084343002/20001
4 years, 5 months ago (2016-06-27 07:27:30 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/207484)
4 years, 5 months ago (2016-06-27 07:33:03 UTC) #11
targos
On 2016/06/27 07:33:03, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 5 months ago (2016-06-27 07:44:28 UTC) #12
pfeldman
It _should_ be using "git config user.email". Do you do "git cl upload"?
4 years, 5 months ago (2016-06-27 15:36:36 UTC) #13
targos
It did not use "git config user.email" and yes I uploaded with "git cl upload". ...
4 years, 5 months ago (2016-06-28 06:24:50 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2084343002/40001
4 years, 5 months ago (2016-06-28 16:17:38 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/246738)
4 years, 5 months ago (2016-06-28 19:26:40 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2084343002/40001
4 years, 5 months ago (2016-06-29 18:34:00 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/96012)
4 years, 5 months ago (2016-06-29 19:09:17 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2084343002/40001
4 years, 5 months ago (2016-07-01 09:05:23 UTC) #28
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-01 11:44:28 UTC) #30
commit-bot: I haz the power
4 years, 5 months ago (2016-07-01 11:46:06 UTC) #32
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/15c520d2190759f91d23af9b9d20419374af05f6
Cr-Commit-Position: refs/heads/master@{#403438}

Powered by Google App Engine
This is Rietveld 408576698