|
|
Created:
4 years, 6 months ago by targos Modified:
4 years, 5 months ago Reviewers:
pfeldman CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionv8_inspector: fix compat with V8 5.1
R=pfeldman@chromium.org
BUG=
Committed: https://crrev.com/15c520d2190759f91d23af9b9d20419374af05f6
Cr-Commit-Position: refs/heads/master@{#403438}
Patch Set 1 #Patch Set 2 : v8_inspector: fix comment in V8Compat #Patch Set 3 : change my email in AUTHORS #Messages
Total messages: 32 (16 generated)
On 2016/06/22 10:45:33, targos wrote: https://codereview.chromium.org/2081233002/ took care of it. yours is better, but that one has landed...
Message was sent while issue was closed.
Description was changed from ========== v8_inspector: fix compat with V8 5.1 R=pfeldman@chromium.org BUG= ========== to ========== v8_inspector: fix compat with V8 5.1 R=pfeldman@chromium.org BUG= ==========
The CQ bit was checked by mic.besace@gmail.com
The CQ bit was unchecked by mic.besace@gmail.com
Following @ofrobots suggestion, I updated the CL just to fix the comment.
The CQ bit was checked by pfeldman@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
On 2016/06/27 07:33:03, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) Is it getting my email address from my Google account ? Because I put the one from my git config in the AUTHORS file.
It _should_ be using "git config user.email". Do you do "git cl upload"?
The CQ bit was checked by mic.besace@gmail.com
The patchset sent to the CQ was uploaded after l-g-t-m from pfeldman@chromium.org Link to the patchset: https://codereview.chromium.org/2084343002/#ps40001 (title: "change my email in AUTHORS")
The CQ bit was unchecked by mic.besace@gmail.com
It did not use "git config user.email" and yes I uploaded with "git cl upload". But it's OK, I don't mind changing my email for this repo.
The CQ bit was checked by pfeldman@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from pfeldman@chromium.org Link to the patchset: https://codereview.chromium.org/2084343002/#ps40001 (title: "change my email in AUTHORS")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by mic.besace@gmail.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by mic.besace@gmail.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== v8_inspector: fix compat with V8 5.1 R=pfeldman@chromium.org BUG= ========== to ========== v8_inspector: fix compat with V8 5.1 R=pfeldman@chromium.org BUG= ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== v8_inspector: fix compat with V8 5.1 R=pfeldman@chromium.org BUG= ========== to ========== v8_inspector: fix compat with V8 5.1 R=pfeldman@chromium.org BUG= Committed: https://crrev.com/15c520d2190759f91d23af9b9d20419374af05f6 Cr-Commit-Position: refs/heads/master@{#403438} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/15c520d2190759f91d23af9b9d20419374af05f6 Cr-Commit-Position: refs/heads/master@{#403438} |