src/x64/stub-cache-x64.cc - Issue 20843012: Extract hardcoded error strings into a single place and replace them with enum.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/stub-cache-x64.cc

Issue 20843012: Extract hardcoded error strings into a single place and replace them with enum. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: styles fixed Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

Index: src/x64/stub-cache-x64.cc

diff --git a/src/x64/stub-cache-x64.cc b/src/x64/stub-cache-x64.cc

index 39ff656ec45be81f7fa5c9c633b4dbe92c227981..7dd2a86c9b3999a84522094eeb45c286bf29bbcd 100644

--- a/src/x64/stub-cache-x64.cc

+++ b/src/x64/stub-cache-x64.cc

@@ -2938,7 +2938,7 @@ Handle<Code> LoadStubCompiler::CompileLoadGlobal(

__ j(equal, &miss);

} else if (FLAG_debug_code) {

__ CompareRoot(rbx, Heap::kTheHoleValueRootIndex);

- __ Check(not_equal, "DontDelete cells can't contain the hole");

+ __ Check(not_equal, kDontDeleteCellsCanTContainTheHole);

}

HandlerFrontendFooter(name, &success, &miss);

« src/compiler.cc ('K') | « src/x64/regexp-macro-assembler-x64.cc ('k') | test/cctest/test-code-stubs-ia32.cc » ('j') | no next file with comments »