Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Side by Side Diff: src/x64/stub-cache-x64.cc

Issue 20843012: Extract hardcoded error strings into a single place and replace them with enum. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: styles fixed Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2920 matching lines...) Expand 10 before | Expand all | Expand 10 after
2931 // Get the value from the cell. 2931 // Get the value from the cell.
2932 __ Move(rbx, cell); 2932 __ Move(rbx, cell);
2933 __ movq(rbx, FieldOperand(rbx, PropertyCell::kValueOffset)); 2933 __ movq(rbx, FieldOperand(rbx, PropertyCell::kValueOffset));
2934 2934
2935 // Check for deleted property if property can actually be deleted. 2935 // Check for deleted property if property can actually be deleted.
2936 if (!is_dont_delete) { 2936 if (!is_dont_delete) {
2937 __ CompareRoot(rbx, Heap::kTheHoleValueRootIndex); 2937 __ CompareRoot(rbx, Heap::kTheHoleValueRootIndex);
2938 __ j(equal, &miss); 2938 __ j(equal, &miss);
2939 } else if (FLAG_debug_code) { 2939 } else if (FLAG_debug_code) {
2940 __ CompareRoot(rbx, Heap::kTheHoleValueRootIndex); 2940 __ CompareRoot(rbx, Heap::kTheHoleValueRootIndex);
2941 __ Check(not_equal, "DontDelete cells can't contain the hole"); 2941 __ Check(not_equal, kDontDeleteCellsCanTContainTheHole);
2942 } 2942 }
2943 2943
2944 HandlerFrontendFooter(name, &success, &miss); 2944 HandlerFrontendFooter(name, &success, &miss);
2945 __ bind(&success); 2945 __ bind(&success);
2946 2946
2947 Counters* counters = isolate()->counters(); 2947 Counters* counters = isolate()->counters();
2948 __ IncrementCounter(counters->named_load_global_stub(), 1); 2948 __ IncrementCounter(counters->named_load_global_stub(), 1);
2949 __ movq(rax, rbx); 2949 __ movq(rax, rbx);
2950 __ ret(0); 2950 __ ret(0);
2951 2951
(...skipping 562 matching lines...) Expand 10 before | Expand all | Expand 10 after
3514 TailCallBuiltin(masm, Builtins::kKeyedStoreIC_Slow); 3514 TailCallBuiltin(masm, Builtins::kKeyedStoreIC_Slow);
3515 } 3515 }
3516 } 3516 }
3517 3517
3518 3518
3519 #undef __ 3519 #undef __
3520 3520
3521 } } // namespace v8::internal 3521 } } // namespace v8::internal
3522 3522
3523 #endif // V8_TARGET_ARCH_X64 3523 #endif // V8_TARGET_ARCH_X64
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698