Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 208423016: Web MIDI API renaming: the last step of three step changes (Closed)

Created:
6 years, 9 months ago by Takashi Toyoshima
Modified:
6 years, 9 months ago
Reviewers:
tkent
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Visibility:
Public.

Description

Web MIDI API renaming: the last step of three step changes Remove old functions. Now there are no 'SysEx' and 'sysEx' strings in Web MIDI implementation after this change. Here are a series of changes on this renaming. 1. https://codereview.chromium.org/208243014/ 2. https://codereview.chromium.org/210003002/ 3. this change BUG=349538 TEST=LayoutTests/webmidi Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170062

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -30 lines) Patch
M LayoutTests/webmidi/permission.html View 1 4 chunks +3 lines, -7 lines 0 comments Download
M LayoutTests/webmidi/send_messages.html View 1 1 chunk +0 lines, -4 lines 0 comments Download
M Source/web/MIDIClientProxy.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M public/web/WebMIDIClient.h View 1 chunk +2 lines, -7 lines 0 comments Download
M public/web/WebMIDIClientMock.h View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Takashi Toyoshima
Please take a look. This change is based on the first patch you reviewed.
6 years, 9 months ago (2014-03-24 13:55:54 UTC) #1
tkent
lgtm
6 years, 9 months ago (2014-03-24 13:58:42 UTC) #2
Takashi Toyoshima
The CQ bit was checked by toyoshim@chromium.org
6 years, 9 months ago (2014-03-26 13:26:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/toyoshim@chromium.org/208423016/1
6 years, 9 months ago (2014-03-26 13:26:44 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-26 13:26:49 UTC) #5
commit-bot: I haz the power
Failed to apply patch for LayoutTests/webmidi/permission.html: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 9 months ago (2014-03-26 13:26:50 UTC) #6
Takashi Toyoshima
The CQ bit was checked by toyoshim@chromium.org
6 years, 9 months ago (2014-03-26 13:33:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/toyoshim@chromium.org/208423016/60001
6 years, 9 months ago (2014-03-26 13:33:17 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-26 14:34:11 UTC) #9
Message was sent while issue was closed.
Change committed as 170062

Powered by Google App Engine
This is Rietveld 408576698