Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Unified Diff: public/web/WebMIDIClient.h

Issue 208423016: Web MIDI API renaming: the last step of three step changes (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/MIDIClientProxy.cpp ('k') | public/web/WebMIDIClientMock.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: public/web/WebMIDIClient.h
diff --git a/public/web/WebMIDIClient.h b/public/web/WebMIDIClient.h
index 47b4e00e4350ff0baf52abc06d63b2a346b165d5..86f39c10261236ca29ba6aeab52af47f512856c2 100644
--- a/public/web/WebMIDIClient.h
+++ b/public/web/WebMIDIClient.h
@@ -39,14 +39,9 @@ public:
virtual ~WebMIDIClient() { }
// Request a permission to use system exclusive messages. Called when MIDIOptions.sysex is true.
- // FIXME: Make following new functions pure virtual once Chromium implements them.
- virtual void requestSysexPermission(const WebMIDIPermissionRequest&) { };
+ virtual void requestSysexPermission(const WebMIDIPermissionRequest&) = 0;
// Cancel the request since the requesting frame may be moving to a new page.
- virtual void cancelSysexPermissionRequest(const WebMIDIPermissionRequest&) { };
-
- // FIXME: Remove following old functions once Chromium usess new functions.
- virtual void requestSysExPermission(const WebMIDIPermissionRequest&) { };
- virtual void cancelSysExPermissionRequest(const WebMIDIPermissionRequest&) { };
+ virtual void cancelSysexPermissionRequest(const WebMIDIPermissionRequest&) = 0;
};
} // namespace blink
« no previous file with comments | « Source/web/MIDIClientProxy.cpp ('k') | public/web/WebMIDIClientMock.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698