child processes: wait 60 seconds before sending SIGALRM.

content/child/child_thread.cc

Index: content/child/child_thread.cc
diff --git a/content/child/child_thread.cc b/content/child/child_thread.cc
index 05650ade06f688cd69040d437d44b6c508cdb013..08856d3baaf5c18ef2e8fd47a1ca2a4fb6de6fbe 100644
--- a/content/child/child_thread.cc
+++ b/content/child/child_thread.cc
@@ -71,11 +71,11 @@ class SuicideOnChannelErrorFilter : public IPC::ChannelProxy::MessageFilter {
     // So, we install a filter on the channel so that we can process this event
     // here and kill the process.
     //
-    // We want to kill this process after giving it 30 seconds to run the exit
+    // We want to kill this process after giving it 60 seconds to run the exit
     // handlers. SIGALRM has a default disposition of terminating the
     // application.

[Avi (use Gerrit), 2013/08/01 15:17:28]

This comment seems a bit untrue. It says "We want to kill this process after
giving it 60 seconds" yet there is an if() in which the false branch it doesn't
wait.

Perhaps a little rewording?

"If a clean exit is requested, we want to kill this process after giving it 60
seconds to run the exit handlers and write whatever it needs to disk."

and move the discussion about SIGALRM to be on the alarm call.

[asharif1, 2013/08/01 15:22:15]

I don't know if I need braces here. Do you?

     if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kChildCleanExit))
-      alarm(30);
+      alarm(60);
     else
       _exit(0);
   }