child processes: wait 60 seconds before sending SIGALRM.

content/child/child_thread.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/child/child_thread.h"
 
 #include "base/allocator/allocator_extension.h"
 #include "base/base_switches.h"
 #include "base/command_line.h"
 #include "base/lazy_instance.h"
@@ skipping 53 matching lines @@
     // processed (because that message loop is stuck in V8).
     //
     // One could make the browser SIGKILL the renderers, but that leaves open a
     // large window where a browser failure (or a user, manually terminating
     // the browser because "it's stuck") will leave behind a process eating all
     // the CPU.
     //
     // So, we install a filter on the channel so that we can process this event
     // here and kill the process.
     //
-    // We want to kill this process after giving it 30 seconds to run the exit
+    // We want to kill this process after giving it 60 seconds to run the exit
     // handlers. SIGALRM has a default disposition of terminating the
     // application.

[Avi (use Gerrit), 2013/08/01 15:17:28]

This comment seems a bit untrue. It says "We want to kill this process after
giving it 60 seconds" yet there is an if() in which the false branch it doesn't
wait.

Perhaps a little rewording?

"If a clean exit is requested, we want to kill this process after giving it 60
seconds to run the exit handlers and write whatever it needs to disk."

and move the discussion about SIGALRM to be on the alarm call.

[asharif1, 2013/08/01 15:22:15]

I don't know if I need braces here. Do you?

     if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kChildCleanExit))
-      alarm(30);
+      alarm(60);
     else
       _exit(0);
   }
 
  protected:
   virtual ~SuicideOnChannelErrorFilter() {}
 };
 
 #endif  // OS(POSIX)
 
@@ skipping 305 matching lines @@
   // inflight that would addref it.
   Send(new ChildProcessHostMsg_ShutdownRequest);
 }
 
 void ChildThread::EnsureConnected() {
   LOG(INFO) << "ChildThread::EnsureConnected()";
   base::KillProcess(base::GetCurrentProcessHandle(), 0, false);
 }
 
 }  // namespace content