Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2084013004: Revert of Proguard warning suppresions removed (Closed)

Created:
4 years, 6 months ago by aelias_OOO_until_Jul13
Modified:
4 years, 6 months ago
Reviewers:
Peter Wen, agrieve, smaier
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Proguard warning suppresions removed (patchset #3 id:40001 of https://codereview.chromium.org/2069213002/ ) Reason for revert: Reverting on behalf of sheriff, breaks arm64-builder-rel due to SslCertificate suppression still being needed. Original issue's description: > Proguard warning suppresions removed > > Old warning suppressions are kept in proguard.flags file without anyone > caring about them. It seems like removing them has absolutely no effect. > > BUG=619937 > > Committed: https://crrev.com/717861ebc8fd72bcca825c4d5049047a75afd34c > Cr-Commit-Position: refs/heads/master@{#400676} TBR=agrieve@chromium.org,wnwen@chromium.org,smaier@chromium.org NOTRY=true BUG=619937

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -3 lines) Patch
M chrome/android/java/proguard.flags View 3 chunks +18 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
aelias_OOO_until_Jul13
Created Revert of Proguard warning suppresions removed
4 years, 6 months ago (2016-06-21 21:41:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2084013004/1
4 years, 6 months ago (2016-06-21 21:41:32 UTC) #3
aelias_OOO_until_Jul13
Canceled the revert because it seems that the true culprit is downstream patch https://chrome-internal-review.googlesource.com/#/c/265767/
4 years, 6 months ago (2016-06-21 21:55:49 UTC) #6
smaier
4 years, 6 months ago (2016-06-22 17:20:42 UTC) #7
This can be abandoned as
https://chrome-internal-review.googlesource.com/#/c/265916/ was reverted
instead.

Powered by Google App Engine
This is Rietveld 408576698