Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(635)

Issue 2083973002: Add InvalidArgument error type for NotificationDatabase. (Closed)

Created:
4 years, 6 months ago by harkness
Modified:
4 years, 6 months ago
CC:
chromium-reviews, Peter Beverloo, darin-cc_chromium.org, mlamouri+watch-notifications_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add InvalidArgument error type for NotificationDatabase. BUG=621873 Committed: https://crrev.com/e564632b1c1214efcab6a4be0ae5ed4af758fac2 Cr-Commit-Position: refs/heads/master@{#401234}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Update invalid argument error in histograms enum. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M content/browser/notifications/notification_database.h View 1 chunk +4 lines, -1 line 0 comments Download
M content/browser/notifications/notification_database.cc View 1 chunk +2 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 19 (7 generated)
harkness
I found this TODO while I was creating the new BudgetDatabase, so I went ahead ...
4 years, 6 months ago (2016-06-21 10:58:28 UTC) #2
Peter Beverloo
https://codereview.chromium.org/2083973002/diff/1/content/browser/notifications/notification_database.h File content/browser/notifications/notification_database.h (right): https://codereview.chromium.org/2083973002/diff/1/content/browser/notifications/notification_database.h#newcode65 content/browser/notifications/notification_database.h:65: STATUS_INVALID_ARGUMENT = 6, Please update the NotificationDatabaseStatus enumeration in ...
4 years, 6 months ago (2016-06-21 11:00:34 UTC) #4
harkness
Updated histograms.xml.
4 years, 6 months ago (2016-06-21 11:14:18 UTC) #5
Peter Beverloo
lgtm, but please get Chris' review as well (and UMA, of course).
4 years, 6 months ago (2016-06-21 11:16:57 UTC) #6
harkness
@holte, could you please take a look at histograms.xml? Thanks, Jen
4 years, 6 months ago (2016-06-21 13:01:12 UTC) #8
cmumford
lgtm
4 years, 6 months ago (2016-06-21 16:53:15 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2083973002/20001
4 years, 6 months ago (2016-06-21 17:35:44 UTC) #11
Steven Holte
lgtm
4 years, 6 months ago (2016-06-21 17:57:29 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-21 18:44:09 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2083973002/20001
4 years, 6 months ago (2016-06-22 08:52:30 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-22 08:56:39 UTC) #17
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 08:58:20 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e564632b1c1214efcab6a4be0ae5ed4af758fac2
Cr-Commit-Position: refs/heads/master@{#401234}

Powered by Google App Engine
This is Rietveld 408576698