Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Unified Diff: content/browser/notifications/notification_database.cc

Issue 2083973002: Add InvalidArgument error type for NotificationDatabase. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update invalid argument error in histograms enum. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/notifications/notification_database.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/notifications/notification_database.cc
diff --git a/content/browser/notifications/notification_database.cc b/content/browser/notifications/notification_database.cc
index 3b4ba9fc5e3bdcced1bc1f27903b082fba453636..31aa8f2a77e87bfe8cc53b6e4a86e23d9c57f2b4 100644
--- a/content/browser/notifications/notification_database.cc
+++ b/content/browser/notifications/notification_database.cc
@@ -58,8 +58,9 @@ NotificationDatabase::Status LevelDBStatusToStatus(
return NotificationDatabase::STATUS_IO_ERROR;
else if (status.IsNotSupportedError())
return NotificationDatabase::STATUS_NOT_SUPPORTED;
+ else if (status.IsInvalidArgument())
+ return NotificationDatabase::STATUS_INVALID_ARGUMENT;
- // TODO(cmumford): Once leveldb 1.19 is released add IsInvalidArgument().
return NotificationDatabase::STATUS_ERROR_FAILED;
}
« no previous file with comments | « content/browser/notifications/notification_database.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698