Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 2083963002: [cronet] Switch to ensure_goma. (Closed)

Created:
4 years, 6 months ago by jbudorick
Modified:
4 years, 6 months ago
Reviewers:
mef, xunjieli
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Remove unused dependency. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+799 lines, -41 lines) Patch
M scripts/slave/recipe_modules/cronet/api.py View 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/cronet/example.expected/gn_test.json View 4 chunks +57 lines, -3 lines 0 comments Download
M scripts/slave/recipe_modules/cronet/example.expected/local_test.json View 3 chunks +56 lines, -2 lines 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_arm64_builder.json View 4 chunks +57 lines, -3 lines 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_arm64_builder__dbg_.json View 4 chunks +57 lines, -3 lines 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_armv6_builder.json View 4 chunks +57 lines, -3 lines 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_builder.json View 4 chunks +57 lines, -3 lines 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_builder__dbg_.json View 4 chunks +57 lines, -3 lines 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_data_reduction_proxy_builder.json View 4 chunks +57 lines, -3 lines 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_mips_builder.json View 4 chunks +57 lines, -3 lines 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_tester.json View 4 chunks +57 lines, -3 lines 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_x86_builder.json View 4 chunks +57 lines, -3 lines 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_x86_builder__dbg_.json View 4 chunks +57 lines, -3 lines 0 comments Download
M scripts/slave/recipes/cronet.expected/cronet_try.json View 4 chunks +57 lines, -3 lines 0 comments Download
M scripts/slave/recipes/cronet.expected/local_test.json View 4 chunks +57 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
jbudorick
4 years, 6 months ago (2016-06-21 10:11:01 UTC) #2
xunjieli
lgtm
4 years, 6 months ago (2016-06-21 13:57:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2083963002/20001
4 years, 6 months ago (2016-06-21 13:57:49 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 14:01:59 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/build/+/9b6928a2cef965ed9035...

Powered by Google App Engine
This is Rietveld 408576698