scripts/slave/recipe_modules/cronet/api.py - Issue 2083963002: [cronet] Switch to ensure_goma.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/cronet/api.py

Issue 2083963002: [cronet] Switch to ensure_goma. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Remove unused dependency. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: scripts/slave/recipe_modules/cronet/api.py

diff --git a/scripts/slave/recipe_modules/cronet/api.py b/scripts/slave/recipe_modules/cronet/api.py

index e0c1e71e213b7f1995f27158d38e83c908d9dbac..01286dbd69be0205d472b65f1ace683bdd88d191 100644

--- a/scripts/slave/recipe_modules/cronet/api.py

+++ b/scripts/slave/recipe_modules/cronet/api.py

@@ -48,6 +48,8 @@ class CronetApi(recipe_api.RecipeApi):

def build(self, use_revision=True, use_goma=True):

+ if use_goma:

+ self.m.chromium.ensure_goma()

self.m.chromium.runhooks()

if self.m.chromium.c.project_generator.tool == 'gn': # pragma: no cover

assert (self.m.chromium.c.HOST_PLATFORM == 'linux'

« no previous file with comments | « no previous file | scripts/slave/recipe_modules/cronet/example.expected/gn_test.json » ('j') | no next file with comments »