Issue 208393014: Remove [NoHeader] interface extended attribute

Issue 208393014: Remove [NoHeader] interface extended attribute (Closed)

Created:
6 years, 9 months ago by Nils Barth (inactive)

Modified:
6 years, 9 months ago

Reviewers:
haraken

CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, feature-media-reviews_chromium.org, sof, kouhei+bindings_chromium.org, eric.carlson_apple.com, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, haraken, Nate Chapin, philipj_slow, Inactive

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Remove [NoHeader] interface extended attribute Perl cruft: Python compiler assumes a header file exists. This removes a special case and simplifies CG logic by having stub header files if needed. R=haraken BUG=341748 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169906

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update comment #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -18 lines)			Patch
M	Source/bindings/IDLExtendedAttributes.txt	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/bindings/generated_bindings.gyp	View		2 chunks	+9 lines, -0 lines	0 comments	Download
M	Source/bindings/scripts/compute_interfaces_info.py	View		1 chunk	+1 line, -3 lines	0 comments	Download
M	Source/bindings/scripts/generate_global_constructors.py	View	1	3 chunks	+22 lines, -11 lines	0 comments	Download
M	Source/bindings/tests/idls/TestPartialInterfacePython2.idl	View		1 chunk	+0 lines, -1 line	0 comments	Download
A	Source/modules/mediasource/WindowMediaSource.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/modules/mediasource/WindowMediaSource.idl	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/modules/modules.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 14 (0 generated)

Expand Messages | Collapse Messages

haraken

LGTM https://codereview.chromium.org/208393014/diff/1/Source/bindings/scripts/generate_global_constructors.py File Source/bindings/scripts/generate_global_constructors.py (right): https://codereview.chromium.org/208393014/diff/1/Source/bindings/scripts/generate_global_constructors.py#newcode31 Source/bindings/scripts/generate_global_constructors.py:31: // of {{idl_basename}} (corresponding header assumed to exist). ...

6 years, 9 months ago (2014-03-24 06:22:07 UTC) #2

Nils Barth (inactive)

https://codereview.chromium.org/208393014/diff/1/Source/bindings/scripts/generate_global_constructors.py File Source/bindings/scripts/generate_global_constructors.py (right): https://codereview.chromium.org/208393014/diff/1/Source/bindings/scripts/generate_global_constructors.py#newcode31 Source/bindings/scripts/generate_global_constructors.py:31: // of {{idl_basename}} (corresponding header assumed to exist). Revised; ...

6 years, 9 months ago (2014-03-24 06:27:51 UTC) #3

Nils Barth (inactive)

The CQ bit was checked by nbarth@chromium.org

6 years, 9 months ago (2014-03-24 07:22:44 UTC) #4