Remove [NoHeader] interface extended attribute

Source/bindings/scripts/generate_global_constructors.py

 #!/usr/bin/python
 #
 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Generates interface properties on global objects.
 
 Concretely these are implemented as "constructor attributes", meaning
 "attributes whose name ends with Constructor" (special-cased by code generator),
 hence "global constructors" for short.
 
 For reference on global objects, see:
 http://www.chromium.org/blink/webidl/blink-idl-extended-attributes#TOC-GlobalContext-i-
 
 Design document: http://www.chromium.org/developers/design-documents/idl-build
 """
 
 import optparse
 import os
 import re
 import sys
 
 from utilities import get_file_contents, write_file, get_interface_extended_attributes_from_idl, is_callback_interface_from_idl
 
 global_objects = {}
 
 
+HEADER_FORMAT = """
+// Stub header file, required by IDL compiler due to existence
+// of {{idl_basename}} (corresponding header assumed to exist).

[haraken, 2014/03/24 06:22:07]

Would you make this message more descriptive so that non-familiarized developers
can understand why this header file is generated? It would also be a good idea
to use a formal English sentence for this kind of non-trivial comment.

[Nils Barth (inactive), 2014/03/24 06:27:51]

Revised; is it clearer now?

+"""
+
 def parse_options():
     parser = optparse.OptionParser()
     parser.add_option('--idl-files-list', help='file listing IDL files')
     parser.add_option('--write-file-only-if-changed', type='int', help='if true, do not write an output file if it would be identical to the existing one, which avoids unnecessary rebuilds in ninja')
 
     options, args = parser.parse_args()
 
     if options.idl_files_list is None:
         parser.error('Must specify a file listing IDL files using --idl-files-list.')
     if options.write_file_only_if_changed is None:
@@ skipping 46 matching lines @@
         # Extract function name, namely everything before opening '('
         constructor_name = re.sub(r'\(.*', '', named_constructor)
         # Note the reduplicated 'ConstructorConstructor'
         # FIXME: rename to NamedConstructor
         attribute_string = 'attribute %sConstructorConstructor %s' % (interface_name, constructor_name)
         attributes_list.append(extended_string + attribute_string)
 
     return attributes_list
 
 
-def write_global_constructors_partial_interface(interface_name, destination_filename, constructor_attributes_list, only_if_changed):
+def write_global_constructors_partial_interface(interface_name, idl_filename, constructor_attributes_list, only_if_changed):
     # FIXME: replace this with a simple Jinja template
-    lines = (['[\n'] +
-             ['    NoHeader,\n'] +
-             [']\n'] +
-             ['partial interface %s {\n' % interface_name] +
+    lines = (['partial interface %s {\n' % interface_name] +
              ['    %s;\n' % constructor_attribute
               # FIXME: sort by interface name (not first by extended attributes)
               for constructor_attribute in sorted(constructor_attributes_list)] +
              ['};\n'])
-    write_file(''.join(lines), destination_filename, only_if_changed)
+    write_file(''.join(lines), idl_filename, only_if_changed)
+    header_filename = os.path.splitext(idl_filename)[0] + '.h'
+    idl_basename = os.path.basename(idl_filename)
+    write_file(HEADER_FORMAT.format(idl_basename=idl_basename),
+               header_filename, only_if_changed)
 
 
 ################################################################################
 
 def main():
     options, args = parse_options()
 
     # Input IDL files are passed in a file, due to OS command line length
     # limits. This is generated at GYP time, which is ok b/c files are static.
     with open(options.idl_files_list) as idl_files_list:
         idl_files = [line.rstrip('\n') for line in idl_files_list]
 
     # Output IDL files (to generate) are passed at the command line, since
     # these are in the build directory, which is determined at build time, not
     # GYP time.
     # These are passed as pairs of GlobalObjectName, GlobalObject.idl
-    interface_name_filename = [(args[i], args[i + 1])
-                               for i in range(0, len(args), 2)]
+    interface_name_idl_filename = [(args[i], args[i + 1])
+                                   for i in range(0, len(args), 2)]
     global_objects.update(
         (interface_name, {
-            'filename': filename,
+            'idl_filename': idl_filename,
             'constructors': [],
         })
-        for interface_name, filename in interface_name_filename)
+        for interface_name, idl_filename in interface_name_idl_filename)
 
     for idl_filename in idl_files:
         record_global_constructors(idl_filename)
 
     for interface_name, global_object in global_objects.iteritems():
-        write_global_constructors_partial_interface(interface_name, global_object['filename'], global_object['constructors'], options.write_file_only_if_changed)
+        write_global_constructors_partial_interface(
+            interface_name,
+            global_object['idl_filename'],
+            global_object['constructors'],
+            options.write_file_only_if_changed)
 
 
 if __name__ == '__main__':
     sys.exit(main())