Issue 208393010: Revert 258568 "Blink roll 169622:169732"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 208393010: Revert 258568 "Blink roll 169622:169732" (Closed)

Created:
6 years, 9 months ago by jar (doing other things)

Modified:
6 years, 9 months ago

Reviewers:
eseidel

CC:
chromium-reviews, dcheng, viettrungluu

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 258568 "Blink roll 169622:169732" Try to repair Mac ASAN bustage BUG=355388 > Blink roll 169622:169732 > > http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=169623:169732&mode=html > TBR= > BUG= > > Review URL: https://codereview.chromium.org/207983002 TBR=eseidel@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258828

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	trunk/src/DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jar (doing other things)

Committed patchset #1 manually as r258828 (tree was closed).

6 years, 9 months ago (2014-03-23 20:55:40 UTC) #2

eseidel

6 years, 9 months ago (2014-03-24 01:33:18 UTC) #3

Message was sent while issue was closed.

Thanks.

The Blink Autoroller will just roll Blink again automatically.
http://www.chromium.org/blink/blinkrollbot

Since this builder does not seem to be tested by the Chromium CQ, it will likely
break again in the future.

I believe https://codereview.chromium.org/191003006/ was the underlying issue. 
I don't think it's been reverted from Blink yet, but I can click the button to
have one created for it.

Expand Messages | Collapse Messages