Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 207983002: Blink roll 169622:169732 (Closed)

Created:
6 years, 9 months ago by eseidel
Modified:
6 years, 9 months ago
Reviewers:
viettrungluu
CC:
chromium-reviews, vsevik
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
eseidel
The CQ bit was checked by eseidel@chromium.org
6 years, 9 months ago (2014-03-21 10:51:51 UTC) #1
eseidel
This roll was created by the Blink AutoRollBot. http://www.chromium.org/blink/blinkrollbot
6 years, 9 months ago (2014-03-21 10:51:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eseidel@chromium.org/207983002/1
6 years, 9 months ago (2014-03-21 10:52:01 UTC) #3
commit-bot: I haz the power
Change committed as 258568
6 years, 9 months ago (2014-03-21 14:13:08 UTC) #4
viettrungluu
I think this may have broken Mac Asan 64 Builder: http://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Builder/builds/928
6 years, 9 months ago (2014-03-22 06:50:36 UTC) #5
viettrungluu
On 2014/03/22 06:50:36, viettrungluu wrote: > I think this may have broken Mac Asan 64 ...
6 years, 9 months ago (2014-03-22 07:39:11 UTC) #6
viettrungluu
On 2014/03/22 07:39:11, viettrungluu wrote: > On 2014/03/22 06:50:36, viettrungluu wrote: > > I think ...
6 years, 9 months ago (2014-03-22 07:41:31 UTC) #7
viettrungluu
On 2014/03/22 07:41:31, viettrungluu wrote: > On 2014/03/22 07:39:11, viettrungluu wrote: > > On 2014/03/22 ...
6 years, 9 months ago (2014-03-22 07:44:40 UTC) #8
eseidel
6 years, 9 months ago (2014-03-22 16:23:33 UTC) #9
Should we add the mac asan builder to the CQ so contributors (like the
blink roll bot) don't break it?

On Saturday, March 22, 2014, <viettrungluu@chromium.org> wrote:

> On 2014/03/22 07:41:31, viettrungluu wrote:
>
>> On 2014/03/22 07:39:11, viettrungluu wrote:
>> > On 2014/03/22 06:50:36, viettrungluu wrote:
>> > > I think this may have broken Mac Asan 64 Builder:
>> > >
>> > >
>> >
>>
>
> http://build.chromium.org/p/chromium.memory/builders/Mac%
> 25252520ASan%2525252064%25252520Builder/builds/928
>
>  Grr, is this link dead already? Here's a newer one:
>>
>
>
> http://build.chromium.org/p/chromium.memory/builders/Mac%
> 2520ASan%252064%2520Builder/builds/1018
>
> No, rietveld is just mangling links. Grrr. :( Replace the |%25|s with just
> |%|s.
> Kill me now.
>
>
>  >
>> > Probably http://src.chromium.org/viewvc/blink?revision=169638&
>> view=revision
>>
>
>
> https://codereview.chromium.org/207983002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698