Remove references to deprecated version of Windows in base_paths.h

Remove references to deprecated version of Windows in base_paths.h

Also removed the run-time string conversion for some paths on Windows.

Committed: https://crrev.com/565a88025b5752993aabc888da935151996926ec
Cr-Commit-Position: refs/heads/master@{#400843}

[Patrick Monette, 2016-06-20 21:53:35]

pmonette@chromium.org changed reviewers:
+ mark@chromium.org

[Patrick Monette, 2016-06-20 21:53:35]

PTAL. Some cleanup in base_paths comments.

[Mark Mentovai, 2016-06-20 22:17:26]

LGTM

https://codereview.chromium.org/2083813002/diff/1/base/base_paths_win.cc
File base/base_paths_win.cc (right):

https://codereview.chromium.org/2083813002/diff/1/base/base_paths_win.cc#newc...
base/base_paths_win.cc:170: .Append(FILE_PATH_LITERAL("Internet Explorer"))
I would have thought that clang-format would line up the dots. I’d defer to its
preference here.

[Patrick Monette, 2016-06-20 22:35:39]

Thanks!

https://codereview.chromium.org/2083813002/diff/1/base/base_paths_win.cc
File base/base_paths_win.cc (right):

https://codereview.chromium.org/2083813002/diff/1/base/base_paths_win.cc#newc...
base/base_paths_win.cc:170: .Append(FILE_PATH_LITERAL("Internet Explorer"))
On 2016/06/20 22:17:26, Mark Mentovai wrote:
> I would have thought that clang-format would line up the dots. I’d defer to
its
> preference here.

I've rechecked and I confirm that this is what clang-format prefers.

[Patrick Monette, 2016-06-20 22:35:42]

The CQ bit was checked by pmonette@chromium.org

[commit-bot: I haz the power, 2016-06-20 22:36:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2083813002/1

[commit-bot: I haz the power, 2016-06-21 00:03:59]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-21 00:07:19]

Description was changed from

==========
Remove references to deprecated version of Windows in base_paths.h

Also removed the run-time string conversion for some paths on Windows.
==========

to

==========
Remove references to deprecated version of Windows in base_paths.h

Also removed the run-time string conversion for some paths on Windows.

Committed: https://crrev.com/565a88025b5752993aabc888da935151996926ec
Cr-Commit-Position: refs/heads/master@{#400843}
==========

[commit-bot: I haz the power, 2016-06-21 00:07:20]

Patchset 1 (id:??) landed as
https://crrev.com/565a88025b5752993aabc888da935151996926ec
Cr-Commit-Position: refs/heads/master@{#400843}