Remove references to deprecated version of Windows in base_paths.h

base/base_paths_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <windows.h>
 #include <shlobj.h>
 
 #include "base/base_paths.h"
 #include "base/environment.h"
 #include "base/files/file_path.h"
@@ skipping 148 matching lines @@
       break;
     case base::DIR_USER_QUICK_LAUNCH:
       if (!PathService::Get(base::DIR_APP_DATA, &cur))
         return false;
       // According to various sources, appending
       // "Microsoft\Internet Explorer\Quick Launch" to %appdata% is the only
       // reliable way to get the quick launch folder across all versions of
       // Windows.
       // http://stackoverflow.com/questions/76080/how-do-you-reliably-get-the-quick-
       // http://www.microsoft.com/technet/scriptcenter/resources/qanda/sept05/hey0901.mspx
-      cur = cur.AppendASCII("Microsoft")
-                .AppendASCII("Internet Explorer")
-                .AppendASCII("Quick Launch");
+      cur = cur.Append(FILE_PATH_LITERAL("Microsoft"))
+                .Append(FILE_PATH_LITERAL("Internet Explorer"))

[Mark Mentovai, 2016/06/20 22:17:26]

I would have thought that clang-format would line up the dots. I’d defer to its
preference here.

[Patrick Monette, 2016/06/20 22:35:39]

I've rechecked and I confirm that this is what clang-format prefers.

+                .Append(FILE_PATH_LITERAL("Quick Launch"));
       break;
     case base::DIR_TASKBAR_PINS:
       if (!PathService::Get(base::DIR_USER_QUICK_LAUNCH, &cur))
         return false;
-      cur = cur.AppendASCII("User Pinned");
-      cur = cur.AppendASCII("TaskBar");
+      cur = cur.Append(FILE_PATH_LITERAL("User Pinned"));
+      cur = cur.Append(FILE_PATH_LITERAL("TaskBar"));
       break;
     case base::DIR_WINDOWS_FONTS:
       if (FAILED(SHGetFolderPath(
               NULL, CSIDL_FONTS, NULL, SHGFP_TYPE_CURRENT, system_buffer))) {
         return false;
       }
       cur = FilePath(system_buffer);
       break;
     default:
       return false;
   }
 
   *result = cur;
   return true;
 }
 
 }  // namespace base