Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 2083703005: Shorthand serialization should check for var in longhands. (Closed)

Created:
4 years, 6 months ago by ramya.v
Modified:
4 years, 6 months ago
Reviewers:
Timothy Loh
CC:
chromium-reviews, blink-reviews-style_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Shorthand serialization should check for var in longhands. If any subproperty of a shorthand has been set to a variable reference, shorthand is serialized as empty string. BUG=616341 Committed: https://crrev.com/2d82848bccbc6dbd246cbc329401774f97f5fa1c Cr-Commit-Position: refs/heads/master@{#401267}

Patch Set 1 #

Patch Set 2 : Added test case #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/fast/css/cssText-shorthand.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/StylePropertySerializer.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
ramya.v
PTAL! Thanks
4 years, 6 months ago (2016-06-22 11:12:19 UTC) #2
Timothy Loh
On 2016/06/22 11:12:19, ramya.v wrote: > PTAL! > > Thanks
4 years, 6 months ago (2016-06-22 11:21:12 UTC) #3
Timothy Loh
On 2016/06/22 11:21:12, Timothy Loh wrote: > On 2016/06/22 11:12:19, ramya.v wrote: > > PTAL! ...
4 years, 6 months ago (2016-06-22 11:21:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2083703005/20001
4 years, 6 months ago (2016-06-22 11:27:08 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-22 13:16:52 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 13:18:35 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2d82848bccbc6dbd246cbc329401774f97f5fa1c
Cr-Commit-Position: refs/heads/master@{#401267}

Powered by Google App Engine
This is Rietveld 408576698