Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Unified Diff: third_party/WebKit/Source/core/css/StylePropertySerializer.cpp

Issue 2083703005: Shorthand serialization should check for var in longhands. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added test case Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css/cssText-shorthand.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/css/StylePropertySerializer.cpp
diff --git a/third_party/WebKit/Source/core/css/StylePropertySerializer.cpp b/third_party/WebKit/Source/core/css/StylePropertySerializer.cpp
index ae217b6d488130767845519d84ab027f648ea01a..9f8264f52773f604f8d37cd5a99c2d9ebb68be27 100644
--- a/third_party/WebKit/Source/core/css/StylePropertySerializer.cpp
+++ b/third_party/WebKit/Source/core/css/StylePropertySerializer.cpp
@@ -400,6 +400,8 @@ String StylePropertySerializer::commonShorthandChecks(const StylePropertyShortha
// TODO(timloh): This should also check unset
if (value.isInheritedValue())
return emptyString();
+ if (value.isVariableReferenceValue())
+ return emptyString();
}
return String();
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css/cssText-shorthand.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698