Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2083603003: Re-land MD Settings fix for crash on back/forward navigation (Closed)

Created:
4 years, 6 months ago by michaelpg
Modified:
4 years, 6 months ago
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, benwells
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-land MD Settings fix for crash on back/forward navigation Re-land of https://codereview.chromium.org/2076083003/ but disable test for now due to revert in https://codereview.chromium.org/2082563002/ BUG=620370 R=groby@chromium.org,dbeam@chromium.org Committed: https://crrev.com/c6a9b5091b097e50943e89b6511065fbdc8dd4d6 Cr-Commit-Position: refs/heads/master@{#400744}

Patch Set 1 #

Patch Set 2 : sanity check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -8 lines) Patch
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_ui.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_ui.cc View 2 chunks +1 line, -6 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_ui_browsertest.cc View 1 chunk +26 lines, -1 line 0 comments Download

Dependent Patchsets:

Issue 2088473002 Patch 40001

Messages

Total messages: 8 (2 generated)
michaelpg
PTAL, we do need to investigate the test flake but this is a P1 regression ...
4 years, 6 months ago (2016-06-20 17:14:28 UTC) #1
groby-ooo-7-16
lgtm
4 years, 6 months ago (2016-06-20 17:47:23 UTC) #2
Dan Beam
lgtm
4 years, 6 months ago (2016-06-20 18:20:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2083603003/1
4 years, 6 months ago (2016-06-20 18:21:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-20 19:05:14 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 19:08:14 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/c6a9b5091b097e50943e89b6511065fbdc8dd4d6
Cr-Commit-Position: refs/heads/master@{#400744}

Powered by Google App Engine
This is Rietveld 408576698