chrome/browser/ui/webui/settings/md_settings_ui.h - Issue 2083603003: Re-land MD Settings fix for crash on back/forward navigation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/settings/md_settings_ui.h

Issue 2083603003: Re-land MD Settings fix for crash on back/forward navigation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: sanity check Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc ('k') | chrome/browser/ui/webui/settings/md_settings_ui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/settings/md_settings_ui.h

diff --git a/chrome/browser/ui/webui/settings/md_settings_ui.h b/chrome/browser/ui/webui/settings/md_settings_ui.h

index 8c48fae237fc9d17fb34323bf7e41aefd805f164..6f49d402e08debbdd4f54e15c60ef26ba750007d 100644

--- a/chrome/browser/ui/webui/settings/md_settings_ui.h

+++ b/chrome/browser/ui/webui/settings/md_settings_ui.h

@@ -12,6 +12,8 @@

#include "content/public/browser/web_contents_observer.h"

#include "content/public/browser/web_ui_controller.h"

+class GURL;

namespace settings {

class SettingsPageUIHandler;

@@ -20,7 +22,7 @@ class SettingsPageUIHandler;

class MdSettingsUI : public content::WebUIController,

public content::WebContentsObserver {

public:

- explicit MdSettingsUI(content::WebUI* web_ui);

+ MdSettingsUI(content::WebUI* web_ui, const GURL& url);

~MdSettingsUI() override;

// content::WebContentsObserver:

« no previous file with comments | « chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc ('k') | chrome/browser/ui/webui/settings/md_settings_ui.cc » ('j') | no next file with comments »