Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2083533002: [NTP Snippets] Shut down the service on database failure (Closed)

Created:
4 years, 6 months ago by Marc Treib
Modified:
4 years, 6 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, zine-eng+reviews_google.com
Base URL:
https://chromium.googlesource.com/chromium/src.git@image_db_tests
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NTP Snippets] Shut down the service on database failure BUG=605870 Committed: https://crrev.com/2241c15a71cb24a92593a2c88629554c205678a6 Cr-Commit-Position: refs/heads/master@{#400929}

Patch Set 1 #

Patch Set 2 : comments #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -28 lines) Patch
M components/ntp_snippets/ntp_snippets_database.h View 1 4 chunks +11 lines, -2 lines 2 comments Download
M components/ntp_snippets/ntp_snippets_database.cc View 12 chunks +27 lines, -24 lines 0 comments Download
M components/ntp_snippets/ntp_snippets_service.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/ntp_snippets/ntp_snippets_service.cc View 4 chunks +16 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (3 generated)
Marc Treib
This turned out way simpler than I imagined :) PTAL!
4 years, 6 months ago (2016-06-20 14:50:59 UTC) #2
Bernhard Bauer
LGTM! https://codereview.chromium.org/2083533002/diff/20001/components/ntp_snippets/ntp_snippets_database.h File components/ntp_snippets/ntp_snippets_database.h (right): https://codereview.chromium.org/2083533002/diff/20001/components/ntp_snippets/ntp_snippets_database.h#newcode122 components/ntp_snippets/ntp_snippets_database.h:122: base::Closure error_callback_; At some point you could think ...
4 years, 6 months ago (2016-06-20 17:37:47 UTC) #3
Marc Treib
https://codereview.chromium.org/2083533002/diff/20001/components/ntp_snippets/ntp_snippets_database.h File components/ntp_snippets/ntp_snippets_database.h (right): https://codereview.chromium.org/2083533002/diff/20001/components/ntp_snippets/ntp_snippets_database.h#newcode122 components/ntp_snippets/ntp_snippets_database.h:122: base::Closure error_callback_; On 2016/06/20 17:37:46, Bernhard Bauer wrote: > ...
4 years, 6 months ago (2016-06-21 08:27:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2083533002/20001
4 years, 6 months ago (2016-06-21 08:28:07 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-21 09:19:40 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 09:21:38 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2241c15a71cb24a92593a2c88629554c205678a6
Cr-Commit-Position: refs/heads/master@{#400929}

Powered by Google App Engine
This is Rietveld 408576698