[NTP Snippets] Shut down the service on database failure

[NTP Snippets] Shut down the service on database failure

BUG=605870
Committed: https://crrev.com/2241c15a71cb24a92593a2c88629554c205678a6
Cr-Commit-Position: refs/heads/master@{#400929}

[Marc Treib, 2016-06-20 14:50:58]

treib@chromium.org changed reviewers:
+ bauerb@chromium.org

[Marc Treib, 2016-06-20 14:50:59]

This turned out way simpler than I imagined :)
PTAL!

[Bernhard Bauer, 2016-06-20 17:37:47]

LGTM!

https://codereview.chromium.org/2083533002/diff/20001/components/ntp_snippets...
File components/ntp_snippets/ntp_snippets_database.h (right):

https://codereview.chromium.org/2083533002/diff/20001/components/ntp_snippets...
components/ntp_snippets/ntp_snippets_database.h:122: base::Closure
error_callback_;
At some point you could think about switching to a client interface instead of
having multiple callbacks and lists thereof.

[Marc Treib, 2016-06-21 08:27:48]

https://codereview.chromium.org/2083533002/diff/20001/components/ntp_snippets...
File components/ntp_snippets/ntp_snippets_database.h (right):

https://codereview.chromium.org/2083533002/diff/20001/components/ntp_snippets...
components/ntp_snippets/ntp_snippets_database.h:122: base::Closure
error_callback_;
On 2016/06/20 17:37:46, Bernhard Bauer wrote:
> At some point you could think about switching to a client interface instead of
> having multiple callbacks and lists thereof.

Hm, true. I generally like explicit callbacks because it's often convenient for
the client to bind their own parameters to them, but maybe the point has come to
switch over to a client interface here...

[Marc Treib, 2016-06-21 08:27:58]

The CQ bit was checked by treib@chromium.org

[commit-bot: I haz the power, 2016-06-21 08:28:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2083533002/20001

[commit-bot: I haz the power, 2016-06-21 09:19:40]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-21 09:21:37]

Description was changed from

==========
[NTP Snippets] Shut down the service on database failure

BUG=605870
==========

to

==========
[NTP Snippets] Shut down the service on database failure

BUG=605870

Committed: https://crrev.com/2241c15a71cb24a92593a2c88629554c205678a6
Cr-Commit-Position: refs/heads/master@{#400929}
==========

[commit-bot: I haz the power, 2016-06-21 09:21:38]

Patchset 2 (id:??) landed as
https://crrev.com/2241c15a71cb24a92593a2c88629554c205678a6
Cr-Commit-Position: refs/heads/master@{#400929}