[NTP Snippets] Extend NTPSnippetsDatabase tests for images

[NTP Snippets] Extend NTPSnippetsDatabase tests for images
Also clean up the existing tests a bit

BUG=605870
Committed: https://crrev.com/509a7f00acc736e6e528642ed1c982295ad69c25
Cr-Commit-Position: refs/heads/master@{#400651}

[Marc Treib, 2016-06-17 16:21:40]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-17 16:21:55]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2079833002/1

[Marc Treib, 2016-06-17 16:21:59]

treib@chromium.org changed reviewers:
+ bauerb@chromium.org

[Marc Treib, 2016-06-17 16:21:59]

Better late than never :)  PTAL!

[commit-bot: I haz the power, 2016-06-17 16:54:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-17 16:54:57]

Dry run: This issue passed the CQ dry run.

[Bernhard Bauer, 2016-06-20 10:13:01]

lgtm

https://codereview.chromium.org/2079833002/diff/1/components/ntp_snippets/ntp...
File components/ntp_snippets/ntp_snippets_database_unittest.cc (right):

https://codereview.chromium.org/2079833002/diff/1/components/ntp_snippets/ntp...
components/ntp_snippets/ntp_snippets_database_unittest.cc:262:
db()->SaveImage(snippet->id(), image_data);
Do you want to flush the runloop after this? The tasks are running sequentially,
but it might be good just in case.

[Marc Treib, 2016-06-20 10:17:18]

https://codereview.chromium.org/2079833002/diff/1/components/ntp_snippets/ntp...
File components/ntp_snippets/ntp_snippets_database_unittest.cc (right):

https://codereview.chromium.org/2079833002/diff/1/components/ntp_snippets/ntp...
components/ntp_snippets/ntp_snippets_database_unittest.cc:262:
db()->SaveImage(snippet->id(), image_data);
On 2016/06/20 10:13:00, Bernhard Bauer wrote:
> Do you want to flush the runloop after this? The tasks are running
sequentially,
> but it might be good just in case.

Done.

[Marc Treib, 2016-06-20 10:17:22]

The CQ bit was checked by treib@chromium.org

[Marc Treib, 2016-06-20 10:17:23]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org
Link to the patchset: https://codereview.chromium.org/2079833002/#ps20001
(title: "review")

[commit-bot: I haz the power, 2016-06-20 10:17:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2079833002/20001

[commit-bot: I haz the power, 2016-06-20 11:13:03]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-20 11:16:15]

Description was changed from

==========
[NTP Snippets] Extend NTPSnippetsDatabase tests for images
Also clean up the existing tests a bit

BUG=605870
==========

to

==========
[NTP Snippets] Extend NTPSnippetsDatabase tests for images
Also clean up the existing tests a bit

BUG=605870

Committed: https://crrev.com/509a7f00acc736e6e528642ed1c982295ad69c25
Cr-Commit-Position: refs/heads/master@{#400651}
==========

[commit-bot: I haz the power, 2016-06-20 11:16:17]

Patchset 2 (id:??) landed as
https://crrev.com/509a7f00acc736e6e528642ed1c982295ad69c25
Cr-Commit-Position: refs/heads/master@{#400651}