Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 2083523002: Reland of "Implement WASM big-endian support". (Closed)

Created:
4 years, 6 months ago by ivica.bogosavljevic
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com, Benedikt Meurer
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of "Implement WASM big-endian support". Reland of https://codereview.chromium.org/2034093002 (reverted by https://codereview.chromium.org/2080153002). Original commit message: Implement WASM support on big-endian platforms. WASM has an implicit requirement that it is running on little-endian machine. We achieve WASM support on BE by keeping data in memory in little-endian order, and changing data endianness before storing to memory and after loading from memory. BUG= Committed: https://crrev.com/77546feb8509999ec490dd0a5e6dc13bbd91f10b Cr-Commit-Position: refs/heads/master@{#37373}

Patch Set 1 : Original commit #

Patch Set 2 : Fix for ARM crashes on Chromebooks #

Patch Set 3 : Specify constant type explicitly because of precision lost on 32bit architectures #

Patch Set 4 : Rebase to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+282 lines, -168 lines) Patch
M src/compiler/wasm-compiler.h View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/wasm-compiler.cc View 1 2 3 3 chunks +139 lines, -0 lines 0 comments Download
M src/utils.h View 1 2 chunks +33 lines, -6 lines 0 comments Download
M src/wasm/decoder.h View 1 2 3 2 chunks +3 lines, -37 lines 0 comments Download
M src/wasm/encoder.h View 1 chunk +2 lines, -14 lines 0 comments Download
M src/wasm/wasm-interpreter.cc View 1 2 3 2 chunks +29 lines, -29 lines 0 comments Download
M test/cctest/cctest.status View 1 chunk +0 lines, -19 lines 0 comments Download
M test/cctest/wasm/test-run-wasm.cc View 1 2 3 18 chunks +49 lines, -47 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-64.cc View 7 chunks +12 lines, -12 lines 0 comments Download
M test/cctest/wasm/wasm-run-utils.h View 1 2 3 1 chunk +12 lines, -4 lines 0 comments Download

Messages

Total messages: 31 (13 generated)
ivica.bogosavljevic
PTAL This CL fixes crashes on Chromebooks. I guess the reason for crash is that ...
4 years, 6 months ago (2016-06-20 12:36:39 UTC) #3
john.yan
lgtm
4 years, 6 months ago (2016-06-20 20:26:27 UTC) #4
ivica.bogosavljevic
PTAL ChangeEndianness wasn't working well on 32bit architectures, because 0xFFl << 48 on 32bit architectures ...
4 years, 6 months ago (2016-06-21 06:53:48 UTC) #5
ivica.bogosavljevic
Reminder...
4 years, 6 months ago (2016-06-23 11:04:24 UTC) #6
john.yan
cc bmeurer@chromium.org, would you be able to help landing this one again please?
4 years, 5 months ago (2016-06-28 17:44:22 UTC) #8
Benedikt Meurer
Sure, LGTM.
4 years, 5 months ago (2016-06-29 03:51:28 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2083523002/60001
4 years, 5 months ago (2016-06-29 07:19:20 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng/builds/4167) v8_win_nosnap_shared_rel_ng_triggered on ...
4 years, 5 months ago (2016-06-29 07:40:16 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2083523002/60001
4 years, 5 months ago (2016-06-29 08:06:32 UTC) #15
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-29 08:24:48 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2083523002/60001
4 years, 5 months ago (2016-06-29 08:26:36 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/18330)
4 years, 5 months ago (2016-06-29 08:30:30 UTC) #22
ivica.bogosavljevic
Missing LGTM from an OWNER for these files: src/wasm/decoder.h src/wasm/encoder.h src/wasm/wasm-interpreter.cc
4 years, 5 months ago (2016-06-29 08:39:23 UTC) #23
titzer
lgtm
4 years, 5 months ago (2016-06-29 08:41:11 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2083523002/60001
4 years, 5 months ago (2016-06-29 08:52:54 UTC) #26
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-06-29 09:25:36 UTC) #28
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/77546feb8509999ec490dd0a5e6dc13bbd91f10b Cr-Commit-Position: refs/heads/master@{#37373}
4 years, 5 months ago (2016-06-29 09:26:42 UTC) #30
john.yan
4 years, 5 months ago (2016-06-29 13:14:32 UTC) #31
Message was sent while issue was closed.
On 2016/06/29 08:41:11, titzer wrote:
> lgtm

Thank you!

Powered by Google App Engine
This is Rietveld 408576698