Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Issue 2080153002: Revert of Implement WASM big-endian support (Closed)

Created:
4 years, 6 months ago by Michael Achenbach
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Implement WASM big-endian support (patchset #5 id:80001 of https://codereview.chromium.org/2034093002/ ) Reason for revert: [Sheriff] Speculative revert for crashes on chrubuntu chromebooks: https://build.chromium.org/p/client.v8.ports/builders/V8%20Arm/builds/320 Original issue's description: > Implement WASM big-endian support. > > Implement WASM support on big-endian platforms. WASM has > an implicit requirement that it is running on little-endian > machine. We achieve WASM support on BE by keeping data > in memory in little-endian order, and changing data > endianness before storing to memory and after loading from > memory. > > BUG= > > Committed: https://crrev.com/d3f3f6c8186b2a53f0c539f7bba0c3708c4d83f9 > Cr-Commit-Position: refs/heads/master@{#37065} TBR=titzer@chromium.org,akos.palfi@imgtec.com,balazs.kilvady@imgtec.com,jyan@ca.ibm.com,ivica.bogosavljevic@imgtec.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= Committed: https://crrev.com/093df3fafc8cdcfac4f87d0dddcf442f29f32786 Cr-Commit-Position: refs/heads/master@{#37091}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -267 lines) Patch
M src/compiler/wasm-compiler.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/compiler/wasm-compiler.cc View 3 chunks +0 lines, -130 lines 0 comments Download
M src/utils.h View 1 chunk +0 lines, -27 lines 0 comments Download
M src/wasm/decoder.h View 2 chunks +37 lines, -3 lines 0 comments Download
M src/wasm/encoder.h View 1 chunk +14 lines, -2 lines 0 comments Download
M src/wasm/wasm-interpreter.cc View 2 chunks +29 lines, -29 lines 0 comments Download
M test/cctest/cctest.status View 1 chunk +19 lines, -0 lines 0 comments Download
M test/cctest/wasm/test-run-wasm.cc View 18 chunks +47 lines, -49 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-64.cc View 7 chunks +12 lines, -12 lines 0 comments Download
M test/cctest/wasm/wasm-run-utils.h View 1 chunk +4 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Michael Achenbach
Created Revert of Implement WASM big-endian support
4 years, 6 months ago (2016-06-20 07:08:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2080153002/1
4 years, 6 months ago (2016-06-20 07:08:43 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-20 07:50:41 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/093df3fafc8cdcfac4f87d0dddcf442f29f32786 Cr-Commit-Position: refs/heads/master@{#37091}
4 years, 6 months ago (2016-06-20 07:53:43 UTC) #7
Michael Achenbach
4 years, 6 months ago (2016-06-20 13:06:36 UTC) #8
Message was sent while issue was closed.
FYI: Revert made the bots green...

Powered by Google App Engine
This is Rietveld 408576698