net/proxy/mojo_proxy_resolver_v8_tracing_bindings_unittest.cc - Issue 2083463002: Replace //net TypeConverters with StructTraits.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/proxy/mojo_proxy_resolver_v8_tracing_bindings_unittest.cc

Issue 2083463002: Replace //net TypeConverters with StructTraits. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@type-converter-cleanup--gurl

Patch Set: rebase Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« net/dns/mojo_host_resolver_impl.h ('K') | « net/proxy/mojo_proxy_resolver_v8_tracing_bindings.h ('k') | net/proxy/mojo_proxy_struct_traits.h » ('j') | net/proxy/mojo_proxy_struct_traits.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/proxy/mojo_proxy_resolver_v8_tracing_bindings_unittest.cc

diff --git a/net/proxy/mojo_proxy_resolver_v8_tracing_bindings_unittest.cc b/net/proxy/mojo_proxy_resolver_v8_tracing_bindings_unittest.cc

index b743d3e0ce1caee433750fa3cbd029d20ba27372..6b6bd157a76fa673d3d912827ee9754ec0127fa4 100644

--- a/net/proxy/mojo_proxy_resolver_v8_tracing_bindings_unittest.cc

+++ b/net/proxy/mojo_proxy_resolver_v8_tracing_bindings_unittest.cc

@@ -31,7 +31,7 @@ class MojoProxyResolverV8TracingBindingsTest : public testing::Test {

errors_.push_back(std::make_pair(line_number, message.To<std::string>()));

}

- void ResolveDns(interfaces::HostResolverRequestInfoPtr request_info,

+ void ResolveDns(std::unique_ptr<HostResolver::RequestInfo> request_info,

interfaces::HostResolverRequestClientPtr client) {}

protected: