net/dns/mojo_host_resolver_impl.h - Issue 2083463002: Replace //net TypeConverters with StructTraits.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/dns/mojo_host_resolver_impl.h

Issue 2083463002: Replace //net TypeConverters with StructTraits. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@type-converter-cleanup--gurl

Patch Set: rebase Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/dns/mojo_host_resolver_impl.h

diff --git a/net/dns/mojo_host_resolver_impl.h b/net/dns/mojo_host_resolver_impl.h

index 68eb893e47cbe296675018206ecd34851f287890..8c9eb48cc446f4bbed8e83b5aefc4b61ec790007 100644

--- a/net/dns/mojo_host_resolver_impl.h

+++ b/net/dns/mojo_host_resolver_impl.h

@@ -28,7 +28,7 @@ class MojoHostResolverImpl {

const NetLogWithSource& net_log);

~MojoHostResolverImpl();

- void Resolve(interfaces::HostResolverRequestInfoPtr request_info,

+ void Resolve(std::unique_ptr<HostResolver::RequestInfo> request_info,

dcheng 2016/10/05 05:59:33 Out of curiosity, why pass by std::unique_ptr?

Sam McNally 2016/10/05 22:48:37 HostResolver::RequestInfo isn't default constructi

interfaces::HostResolverRequestClientPtr client);

bool request_in_progress() { return !pending_jobs_.empty(); }

« no previous file with comments | « net/dns/host_resolver_mojo_unittest.cc ('k') | net/dns/mojo_host_resolver_impl.cc » ('j') | net/proxy/mojo_proxy_struct_traits.cc » ('J')