Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright 2015 The Chromium Authors. All rights reserved. | 1 // Copyright 2015 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 #ifndef NET_DNS_MOJO_HOST_RESOLVER_IMPL_H_ | 5 #ifndef NET_DNS_MOJO_HOST_RESOLVER_IMPL_H_ |
| 6 #define NET_DNS_MOJO_HOST_RESOLVER_IMPL_H_ | 6 #define NET_DNS_MOJO_HOST_RESOLVER_IMPL_H_ |
| 7 | 7 |
| 8 #include <set> | 8 #include <set> |
| 9 | 9 |
| 10 #include "base/macros.h" | 10 #include "base/macros.h" |
| (...skipping 10 matching lines...) Expand all Loading... | |
| 21 // destroyed, any outstanding resolver requests are cancelled. If a request's | 21 // destroyed, any outstanding resolver requests are cancelled. If a request's |
| 22 // HostResolverRequestClient is shut down, the associated resolver request is | 22 // HostResolverRequestClient is shut down, the associated resolver request is |
| 23 // cancelled. | 23 // cancelled. |
| 24 class MojoHostResolverImpl { | 24 class MojoHostResolverImpl { |
| 25 public: | 25 public: |
| 26 // |resolver| is expected to outlive |this|. | 26 // |resolver| is expected to outlive |this|. |
| 27 MojoHostResolverImpl(net::HostResolver* resolver, | 27 MojoHostResolverImpl(net::HostResolver* resolver, |
| 28 const NetLogWithSource& net_log); | 28 const NetLogWithSource& net_log); |
| 29 ~MojoHostResolverImpl(); | 29 ~MojoHostResolverImpl(); |
| 30 | 30 |
| 31 void Resolve(interfaces::HostResolverRequestInfoPtr request_info, | 31 void Resolve(std::unique_ptr<HostResolver::RequestInfo> request_info, |
|
dcheng
2016/10/05 05:59:33
Out of curiosity, why pass by std::unique_ptr?
Sam McNally
2016/10/05 22:48:37
HostResolver::RequestInfo isn't default constructi
| |
| 32 interfaces::HostResolverRequestClientPtr client); | 32 interfaces::HostResolverRequestClientPtr client); |
| 33 | 33 |
| 34 bool request_in_progress() { return !pending_jobs_.empty(); } | 34 bool request_in_progress() { return !pending_jobs_.empty(); } |
| 35 | 35 |
| 36 private: | 36 private: |
| 37 class Job; | 37 class Job; |
| 38 | 38 |
| 39 // Removes |job| from the set of pending jobs, and deletes it. | 39 // Removes |job| from the set of pending jobs, and deletes it. |
| 40 void DeleteJob(Job* job); | 40 void DeleteJob(Job* job); |
| 41 | 41 |
| 42 // Resolver for resolving incoming requests. Not owned. | 42 // Resolver for resolving incoming requests. Not owned. |
| 43 net::HostResolver* resolver_; | 43 net::HostResolver* resolver_; |
| 44 | 44 |
| 45 // The NetLogWithSource to be passed to |resolver_| for all requests. | 45 // The NetLogWithSource to be passed to |resolver_| for all requests. |
| 46 const NetLogWithSource net_log_; | 46 const NetLogWithSource net_log_; |
| 47 | 47 |
| 48 // All pending jobs, so they can be cancelled when this service is destroyed. | 48 // All pending jobs, so they can be cancelled when this service is destroyed. |
| 49 // Owns all jobs. | 49 // Owns all jobs. |
| 50 std::set<Job*> pending_jobs_; | 50 std::set<Job*> pending_jobs_; |
| 51 | 51 |
| 52 base::ThreadChecker thread_checker_; | 52 base::ThreadChecker thread_checker_; |
| 53 | 53 |
| 54 DISALLOW_COPY_AND_ASSIGN(MojoHostResolverImpl); | 54 DISALLOW_COPY_AND_ASSIGN(MojoHostResolverImpl); |
| 55 }; | 55 }; |
| 56 | 56 |
| 57 } // namespace net | 57 } // namespace net |
| 58 | 58 |
| 59 #endif // NET_DNS_MOJO_HOST_RESOLVER_IMPL_H_ | 59 #endif // NET_DNS_MOJO_HOST_RESOLVER_IMPL_H_ |
| OLD | NEW |