Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2083453002: [builtins] Introduce proper Float64Tan operator. (Closed)

Created:
4 years, 6 months ago by Benedikt Meurer
Modified:
4 years, 6 months ago
Reviewers:
Yang, ahaas
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Introduce proper Float64Tan operator. Import base::ieee754::tan() from fdlibm and introduce Float64Tan TurboFan operator based on that, similar to what we do for Float64Cos and Float64Sin. Rewrite Math.tan() as TurboFan builtin and use those operators to also inline Math.tan() into optimized TurboFan functions. Drive-by-fix: Kill the %_ConstructDouble intrinsics, and provide only the %ConstructDouble runtime entry for writing tests. BUG=v8:5086, v8:5126 R=yangguo@chromium.org Committed: https://crrev.com/c87168bc8c76cd491f72eb847a962dec2e5ff1fd Cr-Commit-Position: refs/heads/master@{#37087}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+478 lines, -880 lines) Patch
M BUILD.gn View 3 chunks +2 lines, -8 lines 0 comments Download
M src/assembler.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/assembler.cc View 4 chunks +18 lines, -13 lines 0 comments Download
M src/base/ieee754.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/base/ieee754.cc View 2 chunks +188 lines, -0 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/builtins.h View 2 chunks +3 lines, -0 lines 0 comments Download
M src/builtins.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M src/compiler/arm/code-generator-arm.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/code-assembler.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/instruction-codes.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/instruction-scheduler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/instruction-selector.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M src/compiler/js-builtin-reducer.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-builtin-reducer.cc View 2 chunks +15 lines, -0 lines 0 comments Download
M src/compiler/js-intrinsic-lowering.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/js-intrinsic-lowering.cc View 2 chunks +0 lines, -15 lines 0 comments Download
M src/compiler/machine-operator.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/machine-operator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/machine-operator-reducer.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/mips/code-generator-mips.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/opcodes.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/compiler/raw-machine-assembler.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/simplified-operator.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/simplified-operator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/typer.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M src/compiler/verifier.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/crankshaft/arm/lithium-arm.h View 2 chunks +0 lines, -15 lines 0 comments Download
M src/crankshaft/arm/lithium-arm.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/crankshaft/arm/lithium-codegen-arm.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/crankshaft/arm64/lithium-arm64.h View 2 chunks +0 lines, -15 lines 0 comments Download
M src/crankshaft/arm64/lithium-arm64.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/crankshaft/arm64/lithium-codegen-arm64.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M src/crankshaft/hydrogen.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/crankshaft/hydrogen.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M src/crankshaft/hydrogen-instructions.h View 2 chunks +0 lines, -29 lines 0 comments Download
M src/crankshaft/hydrogen-instructions.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/crankshaft/ia32/lithium-codegen-ia32.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M src/crankshaft/ia32/lithium-ia32.h View 2 chunks +0 lines, -15 lines 0 comments Download
M src/crankshaft/ia32/lithium-ia32.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/crankshaft/mips/lithium-codegen-mips.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/crankshaft/mips/lithium-mips.h View 2 chunks +0 lines, -15 lines 0 comments Download
M src/crankshaft/mips/lithium-mips.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/crankshaft/mips64/lithium-codegen-mips64.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/crankshaft/mips64/lithium-mips64.h View 2 chunks +0 lines, -15 lines 0 comments Download
M src/crankshaft/mips64/lithium-mips64.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/crankshaft/x64/lithium-codegen-x64.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M src/crankshaft/x64/lithium-x64.h View 2 chunks +0 lines, -15 lines 0 comments Download
M src/crankshaft/x64/lithium-x64.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/external-reference-table.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M src/js/prologue.js View 2 chunks +0 lines, -6 lines 0 comments Download
M src/runtime/runtime.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/runtime/runtime-maths.cc View 2 chunks +0 lines, -24 lines 0 comments Download
M src/runtime/runtime-test.cc View 1 chunk +9 lines, -0 lines 0 comments Download
D src/third_party/fdlibm/fdlibm.h View 1 chunk +0 lines, -27 lines 0 comments Download
D src/third_party/fdlibm/fdlibm.cc View 1 chunk +0 lines, -228 lines 0 comments Download
M src/third_party/fdlibm/fdlibm.js View 3 chunks +0 lines, -232 lines 0 comments Download
M src/v8.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 1 chunk +8 lines, -0 lines 0 comments Download
D test/mjsunit/asm/construct-double.js View 1 chunk +0 lines, -33 lines 0 comments Download
M test/mjsunit/double-intrinsics.js View 1 chunk +2 lines, -2 lines 0 comments Download
M test/mjsunit/es6/math-log2-log10.js View 1 chunk +2 lines, -2 lines 0 comments Download
M test/unittests/base/ieee754-unittest.cc View 3 chunks +66 lines, -14 lines 0 comments Download
M test/unittests/compiler/js-builtin-reducer-unittest.cc View 2 chunks +78 lines, -0 lines 0 comments Download
M test/unittests/compiler/js-intrinsic-lowering-unittest.cc View 1 chunk +0 lines, -21 lines 0 comments Download
M test/unittests/compiler/machine-operator-reducer-unittest.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M test/unittests/compiler/node-test-utils.h View 1 chunk +1 line, -0 lines 0 comments Download
M test/unittests/compiler/node-test-utils.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Benedikt Meurer
4 years, 6 months ago (2016-06-20 05:16:19 UTC) #1
Benedikt Meurer
Hey Yang, Same thing for tangents. Please take a look. Thanks, Benedikt Andreas: FYI (wasm)
4 years, 6 months ago (2016-06-20 05:17:58 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2083453002/1
4 years, 6 months ago (2016-06-20 05:23:24 UTC) #5
Yang
On 2016/06/20 05:23:24, commit-bot: I haz the power wrote: > Dry run: CQ is trying ...
4 years, 6 months ago (2016-06-20 05:48:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2083453002/1
4 years, 6 months ago (2016-06-20 05:49:09 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-20 05:51:48 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 05:52:06 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c87168bc8c76cd491f72eb847a962dec2e5ff1fd
Cr-Commit-Position: refs/heads/master@{#37087}

Powered by Google App Engine
This is Rietveld 408576698