Add a UseCounter for the Attr.value setter with associated Element

Add a UseCounter for the Attr.value setter with associated Element

This will distinguish between setting the value on a newly created Attr
object from Document.createAttribute() and setting the value on an Attr
object already attached to an Element, e.g. one from Element.attributes.

If the first case is common but the second is rare it won't be possible
to make value readonly, but it could still be possible to drop the
Element association, which is the point of making it readonly.

BUG=none

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169844

[eseidel1, 2014-03-24 02:59:24]

Thanks. Lgtm. Even thought it won't count from email.

On Sunday, March 23, 2014, <philipj@opera.com> wrote:

> Reviewers: jochen,
>
> Description:
> Add a UseCounter for the Attr.value setter with associated Element
>
> This will distinguish between setting the value on a newly created Attr
> object from Document.createAttribute() and setting the value on an Attr
> object already attached to an Element, e.g. one from Element.attributes.
>
> If the first case is common but the second is rare it won't be possible
> to make value readonly, but it could still be possible to drop the
> Element association, which is the point of making it readonly.
>
> BUG=none
>
> Please review this at https://codereview.chromium.org/208333014/
>
> SVN Base: svn://svn.chromium.org/blink/trunk
>
> Affected files (+3, -0 lines):
>   M Source/core/dom/Attr.cpp
>   M Source/core/frame/UseCounter.h
>
>
> Index: Source/core/dom/Attr.cpp
> diff --git a/Source/core/dom/Attr.cpp b/Source/core/dom/Attr.cpp
> index b6ca3b55de050250483078445aa38b99e5b95670..
> 901e711d5b86ce0b21a9565ac6adb543b3e80521 100644
> --- a/Source/core/dom/Attr.cpp
> +++ b/Source/core/dom/Attr.cpp
> @@ -123,6 +123,8 @@ const AtomicString& Attr::valueForBindings() const
>  void Attr::setValueForBindings(const AtomicString& value)
>  {
>      UseCounter::count(document(), UseCounter::AttrSetValue);
> +    if (m_element)
> +        UseCounter::count(document(), UseCounter::
> AttrSetValueWithElement);
>      setValueInternal(value);
>  }
>
> Index: Source/core/frame/UseCounter.h
> diff --git a/Source/core/frame/UseCounter.h b/Source/core/frame/
> UseCounter.h
> index 452ea383e7abb6d9ad4685fb0156aec810d287c1..
> b3f232b03b781dc7682f3c09b52a4f15fa90c863 100644
> --- a/Source/core/frame/UseCounter.h
> +++ b/Source/core/frame/UseCounter.h
> @@ -317,6 +317,7 @@ public:
>          AnimationConstructorKeyframeListEffectObjectTiming = 300,
>          AnimationConstructorKeyframeListEffectDoubleTiming = 301,
>          AnimationConstructorKeyframeListEffectNoTiming = 302,
> +        AttrSetValueWithElement = 303,
>          // Add new features immediately above this line. Don't change
> assigned
>          // numbers of any item, and don't reuse removed slots.
>          NumberOfFeatures, // This enum value must be last.
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[jochen (gone - plz use gerrit), 2014-03-24 12:15:32]

lgtm

[philipj_slow, 2014-03-24 12:46:02]

The CQ bit was checked by philipj@opera.com

[commit-bot: I haz the power, 2014-03-24 12:46:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/philipj@opera.com/208333014/1

[commit-bot: I haz the power, 2014-03-24 12:56:29]

Change committed as 169844

[eseidel, 2014-03-24 16:57:51]

lgtm