Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 208333014: Add a UseCounter for the Attr.value setter with associated Element (Closed)

Created:
6 years, 9 months ago by philipj_slow
Modified:
6 years, 9 months ago
CC:
blink-reviews, sof, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, Inactive, rwlbuis
Visibility:
Public.

Description

Add a UseCounter for the Attr.value setter with associated Element This will distinguish between setting the value on a newly created Attr object from Document.createAttribute() and setting the value on an Attr object already attached to an Element, e.g. one from Element.attributes. If the first case is common but the second is rare it won't be possible to make value readonly, but it could still be possible to drop the Element association, which is the point of making it readonly. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169844

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M Source/core/dom/Attr.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
philipj_slow
6 years, 9 months ago (2014-03-24 02:49:18 UTC) #1
eseidel1
Thanks. Lgtm. Even thought it won't count from email. On Sunday, March 23, 2014, <philipj@opera.com> ...
6 years, 9 months ago (2014-03-24 02:59:24 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years, 9 months ago (2014-03-24 12:15:32 UTC) #3
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 9 months ago (2014-03-24 12:46:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/208333014/1
6 years, 9 months ago (2014-03-24 12:46:07 UTC) #5
commit-bot: I haz the power
Change committed as 169844
6 years, 9 months ago (2014-03-24 12:56:29 UTC) #6
eseidel
6 years, 9 months ago (2014-03-24 16:57:51 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698