Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Side by Side Diff: Source/core/dom/Attr.cpp

Issue 208333014: Add a UseCounter for the Attr.value setter with associated Element (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/core/frame/UseCounter.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Peter Kelly (pmk@post.com) 4 * (C) 2001 Peter Kelly (pmk@post.com)
5 * (C) 2001 Dirk Mueller (mueller@kde.org) 5 * (C) 2001 Dirk Mueller (mueller@kde.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2009, 2010, 2012 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2009, 2010, 2012 Apple Inc. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 105 matching lines...) Expand 10 before | Expand all | Expand 10 after
116 116
117 const AtomicString& Attr::valueForBindings() const 117 const AtomicString& Attr::valueForBindings() const
118 { 118 {
119 UseCounter::count(document(), UseCounter::AttrGetValue); 119 UseCounter::count(document(), UseCounter::AttrGetValue);
120 return value(); 120 return value();
121 } 121 }
122 122
123 void Attr::setValueForBindings(const AtomicString& value) 123 void Attr::setValueForBindings(const AtomicString& value)
124 { 124 {
125 UseCounter::count(document(), UseCounter::AttrSetValue); 125 UseCounter::count(document(), UseCounter::AttrSetValue);
126 if (m_element)
127 UseCounter::count(document(), UseCounter::AttrSetValueWithElement);
126 setValueInternal(value); 128 setValueInternal(value);
127 } 129 }
128 130
129 void Attr::setNodeValue(const String& v) 131 void Attr::setNodeValue(const String& v)
130 { 132 {
131 // Attr uses AtomicString type for its value to save memory as there 133 // Attr uses AtomicString type for its value to save memory as there
132 // is duplication among Elements' attributes values. 134 // is duplication among Elements' attributes values.
133 setValueInternal(AtomicString(v)); 135 setValueInternal(AtomicString(v));
134 } 136 }
135 137
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
195 } 197 }
196 198
197 void Attr::attachToElement(Element* element) 199 void Attr::attachToElement(Element* element)
198 { 200 {
199 ASSERT(!m_element); 201 ASSERT(!m_element);
200 m_element = element; 202 m_element = element;
201 m_standaloneValue = nullAtom; 203 m_standaloneValue = nullAtom;
202 } 204 }
203 205
204 } 206 }
OLDNEW
« no previous file with comments | « no previous file | Source/core/frame/UseCounter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698