Disable drawing of video backgrounds in OverlayFullscreenVideo

Disable drawing of video backgrounds in OverlayFullscreenVideo

This is a follow up to http://crrev.com/1907753002 to fix cases where the
video background is now visible in OverlayFullscreenVideo, where it's not
desired. This forcefully stops the GraphicsLayer associated with the
video from drawing its content (in particular, the background) when OFV
is enabled.

TEST=LayoutTests, manual testing
BUG=615245, 603521
Committed: https://crrev.com/014e89fdbe83fd895898331249f9bba28cc71130
Cr-Commit-Position: refs/heads/master@{#401916}

[watk, 2016-06-22 01:23:00]

Description was changed from

==========
Disable drawing of video backgrounds in OverlayFullscreenVideo

This is a follow up to http://crrev.com/1907753002 to fix cases where the
video background is now visible in OverlayFullscreenVideo, where it's not
desired. This forcefully stops the GraphicsLayer associated with the
video from drawing its content (in particulate, the background) when OFV
is enabled.

TEST=LayoutTests
BUG=615245, 603521
==========

to

==========
Disable drawing of video backgrounds in OverlayFullscreenVideo

This is a follow up to http://crrev.com/1907753002 to fix cases where the
video background is now visible in OverlayFullscreenVideo, where it's not
desired. This forcefully stops the GraphicsLayer associated with the
video from drawing its content (in particulate, the background) when OFV
is enabled.

TEST=LayoutTests, manual testing
BUG=615245, 603521
==========

[watk, 2016-06-22 01:23:00]

watk@chromium.org changed reviewers:
+ chrishtr@chromium.org, foolip@chromium.org

[watk, 2016-06-22 01:23:40]

Description was changed from

==========
Disable drawing of video backgrounds in OverlayFullscreenVideo

This is a follow up to http://crrev.com/1907753002 to fix cases where the
video background is now visible in OverlayFullscreenVideo, where it's not
desired. This forcefully stops the GraphicsLayer associated with the
video from drawing its content (in particulate, the background) when OFV
is enabled.

TEST=LayoutTests, manual testing
BUG=615245, 603521
==========

to

==========
Disable drawing of video backgrounds in OverlayFullscreenVideo

This is a follow up to http://crrev.com/1907753002 to fix cases where the
video background is now visible in OverlayFullscreenVideo, where it's not
desired. This forcefully stops the GraphicsLayer associated with the
video from drawing its content (in particular, the background) when OFV
is enabled.

TEST=LayoutTests, manual testing
BUG=615245, 603521
==========

[watk, 2016-06-22 20:18:47]

PTAL. Two bots failed, but I'm currently re-running them to see if they're
related.

[chrishtr, 2016-06-22 20:23:13]

lgtm

Looks good to me.

Philip: I recommended you as a reviewer also, because the controls for the video
are actually
children of it in the layout tree. However, I think those will always be
separately composited
due to the VideoOverlay trigger, and that the controls are always positioned and
hence have
PaintLayers. (If they didn't have PaintLayers they could not be individually
composited.)

The corner case I want to make sure is covered is any negative z-index,
non-self-composited children of the video. Is that possible?

[watk, 2016-06-23 18:32:40]

On 2016/06/22 20:23:13, chrishtr wrote:
> lgtm
> 
> Looks good to me.
> 
> Philip: I recommended you as a reviewer also, because the controls for the
video
> are actually
> children of it in the layout tree. However, I think those will always be
> separately composited
> due to the VideoOverlay trigger, and that the controls are always positioned
and
> hence have
> PaintLayers. (If they didn't have PaintLayers they could not be individually
> composited.)
> 
> The corner case I want to make sure is covered is any negative z-index,
> non-self-composited children of the video. Is that possible?

foolip@, any thoughts?

[chrishtr, 2016-06-24 16:48:37]

I think you just go ahead and commit this now.

[watk, 2016-06-24 17:35:14]

On 2016/06/24 16:48:37, chrishtr wrote:
> I think you just go ahead and commit this now.

Ah, he's out. Will do, thanks.

[watk, 2016-06-24 17:35:20]

The CQ bit was checked by watk@chromium.org

[commit-bot: I haz the power, 2016-06-24 17:35:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-24 18:57:00]

Description was changed from

==========
Disable drawing of video backgrounds in OverlayFullscreenVideo

This is a follow up to http://crrev.com/1907753002 to fix cases where the
video background is now visible in OverlayFullscreenVideo, where it's not
desired. This forcefully stops the GraphicsLayer associated with the
video from drawing its content (in particular, the background) when OFV
is enabled.

TEST=LayoutTests, manual testing
BUG=615245, 603521
==========

to

==========
Disable drawing of video backgrounds in OverlayFullscreenVideo

This is a follow up to http://crrev.com/1907753002 to fix cases where the
video background is now visible in OverlayFullscreenVideo, where it's not
desired. This forcefully stops the GraphicsLayer associated with the
video from drawing its content (in particular, the background) when OFV
is enabled.

TEST=LayoutTests, manual testing
BUG=615245, 603521
==========

[commit-bot: I haz the power, 2016-06-24 18:57:01]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-24 18:57:58]

Description was changed from

==========
Disable drawing of video backgrounds in OverlayFullscreenVideo

This is a follow up to http://crrev.com/1907753002 to fix cases where the
video background is now visible in OverlayFullscreenVideo, where it's not
desired. This forcefully stops the GraphicsLayer associated with the
video from drawing its content (in particular, the background) when OFV
is enabled.

TEST=LayoutTests, manual testing
BUG=615245, 603521
==========

to

==========
Disable drawing of video backgrounds in OverlayFullscreenVideo

This is a follow up to http://crrev.com/1907753002 to fix cases where the
video background is now visible in OverlayFullscreenVideo, where it's not
desired. This forcefully stops the GraphicsLayer associated with the
video from drawing its content (in particular, the background) when OFV
is enabled.

TEST=LayoutTests, manual testing
BUG=615245, 603521

Committed: https://crrev.com/014e89fdbe83fd895898331249f9bba28cc71130
Cr-Commit-Position: refs/heads/master@{#401916}
==========

[commit-bot: I haz the power, 2016-06-24 18:58:00]

Patchset 1 (id:??) landed as
https://crrev.com/014e89fdbe83fd895898331249f9bba28cc71130
Cr-Commit-Position: refs/heads/master@{#401916}

[foolip, 2016-06-28 10:11:55]

Sorry, I was OOO from Thursday last week until today.