Always create a ContentVideoView when entering fullscreen on Android

Always create a ContentVideoView when entering fullscreen on Android

Previously we were creating the CVV lazily when GpuVideoDecoder
initialized. Now it's created on entering fullscreen.

This makes the transition slightly faster, because we start creating
the CVV earlier. It also lets us use OverlayFullscreenVideo for
software video frames to improve jank, because
OFV requires the CompositorView surface to be translucent.

BUG=603521, 618982
Committed: https://crrev.com/f835a7953bb00d8fe7034f7d1076a6b4996fc605
Cr-Commit-Position: refs/heads/master@{#402009}

[watk, 2016-06-22 01:33:29]

watk@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[watk, 2016-06-22 01:33:29]

This isn't 100% ready yet, so feel free to ignore until it is. But this is the
general idea.

[DaleCurtis, 2016-06-22 01:53:06]

lg2m

[watk, 2016-06-23 22:28:18]

Description was changed from

==========
Always create a ContentVideoView when entering fullscreen on Android

BUG=
==========

to

==========
Always create a ContentVideoView when entering fullscreen on Android

Previously we were creating the CVV lazily when GpuVideoDecoder
initialized. Now it's created on entering fullscreen.

This makes the transition slightly faster, because we start creating
the CVV earlier. It also lets us use OverlayFullscreenVideo for
software video frames to improve jank, because
OFV requires the CompositorView surface to be translucent. 

BUG=603521,618982
==========

[watk, 2016-06-23 22:28:19]

watk@chromium.org changed reviewers:
+ sandersd@chromium.org

[watk, 2016-06-23 22:30:25]

I guess this actually was ready.. I can't break it with a bunch of manual
testing.

PTA careful look sandersd@ because I want to merge this back.

[sandersd (OOO until July 31), 2016-06-23 22:50:51]

https://codereview.chromium.org/2083123003/diff/20001/media/blink/webmediapla...
File media/blink/webmediaplayer_impl.cc (right):

https://codereview.chromium.org/2083123003/diff/20001/media/blink/webmediapla...
media/blink/webmediaplayer_impl.cc:295: fullscreen_surface_id_ =
SurfaceManager::kNoSurfaceID;
If we enter and exit fullscreen fast enough, it looks like this clearing might
be overwritten. In that case, the next time we fullscreen we could use the wrong
surface ID.

Ideally the surface request would be cancelable in some way.

[watk, 2016-06-24 20:26:18]

Good catch. PTAL

https://codereview.chromium.org/2083123003/diff/20001/media/blink/webmediapla...
File media/blink/webmediaplayer_impl.cc (right):

https://codereview.chromium.org/2083123003/diff/20001/media/blink/webmediapla...
media/blink/webmediaplayer_impl.cc:295: fullscreen_surface_id_ =
SurfaceManager::kNoSurfaceID;
On 2016/06/23 22:50:51, sandersd wrote:
> If we enter and exit fullscreen fast enough, it looks like this clearing might
> be overwritten. In that case, the next time we fullscreen we could use the
wrong
> surface ID.
> 
> Ideally the surface request would be cancelable in some way.

Done.

[DaleCurtis, 2016-06-24 20:58:54]

lgtm

[watk, 2016-06-24 21:20:18]

The CQ bit was checked by watk@chromium.org

[commit-bot: I haz the power, 2016-06-24 21:20:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-24 23:24:53]

Description was changed from

==========
Always create a ContentVideoView when entering fullscreen on Android

Previously we were creating the CVV lazily when GpuVideoDecoder
initialized. Now it's created on entering fullscreen.

This makes the transition slightly faster, because we start creating
the CVV earlier. It also lets us use OverlayFullscreenVideo for
software video frames to improve jank, because
OFV requires the CompositorView surface to be translucent. 

BUG=603521,618982
==========

to

==========
Always create a ContentVideoView when entering fullscreen on Android

Previously we were creating the CVV lazily when GpuVideoDecoder
initialized. Now it's created on entering fullscreen.

This makes the transition slightly faster, because we start creating
the CVV earlier. It also lets us use OverlayFullscreenVideo for
software video frames to improve jank, because
OFV requires the CompositorView surface to be translucent. 

BUG=603521,618982
==========

[commit-bot: I haz the power, 2016-06-24 23:24:54]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-24 23:28:01]

Description was changed from

==========
Always create a ContentVideoView when entering fullscreen on Android

Previously we were creating the CVV lazily when GpuVideoDecoder
initialized. Now it's created on entering fullscreen.

This makes the transition slightly faster, because we start creating
the CVV earlier. It also lets us use OverlayFullscreenVideo for
software video frames to improve jank, because
OFV requires the CompositorView surface to be translucent. 

BUG=603521,618982
==========

to

==========
Always create a ContentVideoView when entering fullscreen on Android

Previously we were creating the CVV lazily when GpuVideoDecoder
initialized. Now it's created on entering fullscreen.

This makes the transition slightly faster, because we start creating
the CVV earlier. It also lets us use OverlayFullscreenVideo for
software video frames to improve jank, because
OFV requires the CompositorView surface to be translucent.

BUG=603521,618982

Committed: https://crrev.com/f835a7953bb00d8fe7034f7d1076a6b4996fc605
Cr-Commit-Position: refs/heads/master@{#402009}
==========

[commit-bot: I haz the power, 2016-06-24 23:28:02]

Patchset 3 (id:??) landed as
https://crrev.com/f835a7953bb00d8fe7034f7d1076a6b4996fc605
Cr-Commit-Position: refs/heads/master@{#402009}