Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(882)

Unified Diff: tracing/tracing/model/power_series.html

Issue 2083213002: Change call-sites in trace viewer to use generators instead of iteration functions. (Closed) Base URL: git@github.com:catapult-project/catapult@master
Patch Set: fix break/continue Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tracing/tracing/model/power_series.html
diff --git a/tracing/tracing/model/power_series.html b/tracing/tracing/model/power_series.html
index 24876b3e339ac6b9febbe1cfb0592b27c3a237da..e5343b469cfaa139423260238f7ed71f419f9b43 100644
--- a/tracing/tracing/model/power_series.html
+++ b/tracing/tracing/model/power_series.html
@@ -114,16 +114,11 @@ tr.exportTo('tr.model', function() {
this.bounds.addValue(this.samples_[this.samples_.length - 1].start);
},
- findTopmostSlicesInThisContainer: function(eventPredicate, callback,
- opt_this) {
+ childEvents: function*() {
+ yield * this.samples_;
},
- childEvents: function*(eventTypePredicate, opt_this) {
- if (eventTypePredicate.call(opt_this, PowerSample))
- yield * this.samples_;
- },
-
- childEventContainers: function*(callback, opt_this) {
+ childEventContainers: function*() {
charliea (OOO until 10-5) 2016/06/29 18:08:44 This is default behavior, right?
alexandermont 2016/06/29 20:47:11 Empty function removed now that empty function is
}
};

Powered by Google App Engine
This is Rietveld 408576698