Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: tracing/tracing/model/object_collection.html

Issue 2083213002: Change call-sites in trace viewer to use generators instead of iteration functions. (Closed) Base URL: git@github.com:catapult-project/catapult@master
Patch Set: fix break/continue Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tracing/tracing/model/object_collection.html
diff --git a/tracing/tracing/model/object_collection.html b/tracing/tracing/model/object_collection.html
index 1410b27c3e916b28cf828357daa14e77268fab0c..b0e412cea20aa40f3491e485bf2a1bf40b3b6aed 100644
--- a/tracing/tracing/model/object_collection.html
+++ b/tracing/tracing/model/object_collection.html
@@ -40,21 +40,13 @@ tr.exportTo('tr.model', function() {
ObjectCollection.prototype = {
__proto__: tr.model.EventContainer.prototype,
- findTopmostSlicesInThisContainer: function(eventPredicate, callback,
charliea (OOO until 10-5) 2016/06/29 18:08:44 can this be deleted in a follow-up CL?
alexandermont 2016/06/29 20:47:11 Now default behavior
- opt_this) {
- },
-
childEventContainers: function*() {
},
- childEvents: function*(eventTypePredicate, opt_this) {
- var bI = !!eventTypePredicate.call(opt_this, ObjectInstance);
- var bS = !!eventTypePredicate.call(opt_this, ObjectSnapshot);
+ childEvents: function*() {
for (var instance of this.getAllObjectInstances()) {
- if (bI)
- yield instance;
- if (bS)
- yield * instance.snapshots;
+ yield instance;
+ yield * instance.snapshots;
}
},

Powered by Google App Engine
This is Rietveld 408576698