Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Unified Diff: tracing/tracing/model/device_test.html

Issue 2083213002: Change call-sites in trace viewer to use generators instead of iteration functions. (Closed) Base URL: git@github.com:catapult-project/catapult@master
Patch Set: fix break/continue Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tracing/tracing/model/device_test.html
diff --git a/tracing/tracing/model/device_test.html b/tracing/tracing/model/device_test.html
index e1c5693369209849b4fe2979d485b51191e87d55..b8bb921d27f72935db27bede0023de0940e3fe2d 100644
--- a/tracing/tracing/model/device_test.html
+++ b/tracing/tracing/model/device_test.html
@@ -50,26 +50,5 @@ tr.b.unittest.testSuite(function() {
assert.equal(device.powerSeries.samples[1].start, 202);
});
- test('iterateAllChildEventContainers', function() {
charliea (OOO until 10-5) 2016/06/29 18:08:44 Why delete this?
alexandermont 2016/06/29 20:47:11 I originally deleted it because it was testing a f
- var device = new Device(new Model());
-
- // Power series shouldn't be included as a child until one's set.
- var childEventContainers = [];
- device.iterateAllChildEventContainers(function(eventContainer) {
- childEventContainers.push(eventContainer);
- });
-
- assert.deepEqual(childEventContainers, []);
-
- device.powerSeries = new PowerSeries(device);
-
- // Verify that the power series is now included as a child.
- var childEventContainers = [];
- device.iterateAllChildEventContainers(function(eventContainer) {
- childEventContainers.push(eventContainer);
- });
-
- assert.deepEqual(childEventContainers, [device.powerSeries]);
- });
});
</script>

Powered by Google App Engine
This is Rietveld 408576698