Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: tracing/tracing/model/device.html

Issue 2083213002: Change call-sites in trace viewer to use generators instead of iteration functions. (Closed) Base URL: git@github.com:catapult-project/catapult@master
Patch Set: fix break/continue Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tracing/tracing/model/device.html
diff --git a/tracing/tracing/model/device.html b/tracing/tracing/model/device.html
index d47d684ce8e605ae9faa8468080392c0aa2c1145..b4c4082632fcd2a9ee79e871dbdfc475f9a08bc8 100644
--- a/tracing/tracing/model/device.html
+++ b/tracing/tracing/model/device.html
@@ -78,17 +78,16 @@ tr.exportTo('tr.model', function() {
updateBounds: function() {
this.bounds.reset();
-
- this.iterateAllChildEventContainers(function(child) {
+ for (var child of this.childEventContainers()) {
child.updateBounds();
this.bounds.addRange(child.bounds);
- }, this);
+ }
},
shiftTimestampsForward: function(amount) {
- this.iterateAllChildEventContainers(function(child) {
+ for (var child of this.childEventContainers()) {
child.shiftTimestampsForward(amount);
- });
+ }
for (var i = 0; i < this.vSyncTimestamps_.length; i++)
this.vSyncTimestamps_[i] += amount;
@@ -97,11 +96,7 @@ tr.exportTo('tr.model', function() {
addCategoriesToDict: function(categoriesDict) {
},
- findTopmostSlicesInThisContainer: function(eventPredicate, callback,
- opt_this) {
- },
-
- childEvents: function*(eventTypePredicate, opt_this) {
+ childEvents: function*() {
charliea (OOO until 10-5) 2016/06/29 18:08:44 nit: can delete this if we provide a default ipml
alexandermont 2016/06/29 20:47:11 Done
},
childEventContainers: function*() {

Powered by Google App Engine
This is Rietveld 408576698